From: Michal Hocko <mhocko@suse.com>
To: Dongjoo Seo <dongjoo.linux.dev@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
dave@stgolabs.net, dan.j.williams@intel.com, nifan@outlook.com,
a.manzanares@samsung.com
Subject: Re: [PATCH] mm/page_alloc: fix NUMA stats update for cpu-less nodes
Date: Thu, 24 Oct 2024 00:23:56 +0200 [thread overview]
Message-ID: <Zxl3fB9FVz5i1huh@tiehlicka> (raw)
In-Reply-To: <Zxl1eOooy5lwJwSo@eqbm-smc020.dtc.local>
On Wed 23-10-24 15:15:20, Dongjoo Seo wrote:
> Hi Andrew, Michal,
>
> Thanks for the feedback.
>
> The issue is that CPU-less nodes can lead to incorrect NUMA stats.
> For example, NUMA_HIT may incorrectly increase for CPU-less nodes
> because the current logic doesn't account for whether a node has CPUs.
Define incorrect
Current semantic doesn't really care about cpu less NUMA nodes because
current means whatever is required AFIU. This is certainly a long term
semantic. Why does this need to change and why it makes sense to
pre-existing users?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2024-10-23 22:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 17:50 [PATCH] mm/page_alloc: fix NUMA stats update for cpu-less nodes Dongjoo Seo
2024-10-23 18:03 ` Michal Hocko
2024-10-23 20:41 ` Andrew Morton
2024-10-23 21:38 ` Michal Hocko
2024-10-23 22:15 ` Dongjoo Seo
2024-10-23 22:23 ` Michal Hocko [this message]
2024-10-24 4:54 ` Dongjoo Seo
2024-10-24 8:24 ` Michal Hocko
2024-10-24 18:13 ` Dongjoo Seo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxl3fB9FVz5i1huh@tiehlicka \
--to=mhocko@suse.com \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=dongjoo.linux.dev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nifan@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.