From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 1/1 perf-tools] perf python: Fix up the build on architectures without HAVE_KVM_STAT_SUPPORT
Date: Wed, 23 Oct 2024 19:29:42 -0300 [thread overview]
Message-ID: <Zxl41sigv9Fw7Vqv@x1> (raw)
In-Reply-To: <CAP-5=fVMwVigWsi7-QgBGZ1QbUuPjAxnr5gaLybHtynG7rHU6w@mail.gmail.com>
On Wed, Oct 23, 2024 at 02:48:04PM -0700, Ian Rogers wrote:
> On Wed, Oct 23, 2024 at 2:46 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > On Wed, Oct 23, 2024 at 02:40:45PM -0700, Ian Rogers wrote:
> > > On Wed, Oct 23, 2024 at 2:05 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > > Noticed while building on a raspbian arm 32-bit system.
<SNIP>
> > > > Fixes: 9dabf4003423c8d3 ("perf python: Switch module to linking libraries from building source")
> > > > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > > > Cc: Ian Rogers <irogers@google.com>
> > > > Cc: Jiri Olsa <jolsa@kernel.org>
> > > > Cc: Kan Liang <kan.liang@linux.intel.com>
> > > > Cc: Namhyung Kim <namhyung@kernel.org>
> > > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > > So this will at least conflict with:
> > > https://lore.kernel.org/lkml/20241022173015.437550-6-irogers@google.com/
> > > where the #ifdef-ed out functions are removed. Does that series fix
> > > the ARM32 issue? Could we land that?
> > I'd prefer to have what I posted for perf-tools, as it is smaller, and
> > to land the patch removing those functions on perf-tools-next.
> Makes sense to me. Have a
> Reviewed-by: Ian Rogers <irogers@google.com>
> should you need it.
Always appreciated, thanks, applying it to the patch,
- Arnaldo
> > I'll try to switch testing to a librecomputer board, the rpi3 is super
> > slow :-)
prev parent reply other threads:[~2024-10-23 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 21:05 [PATCH 1/1 perf-tools] perf python: Fix up the build on architectures without HAVE_KVM_STAT_SUPPORT Arnaldo Carvalho de Melo
2024-10-23 21:40 ` Ian Rogers
2024-10-23 21:46 ` Arnaldo Carvalho de Melo
2024-10-23 21:48 ` Ian Rogers
2024-10-23 22:29 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxl41sigv9Fw7Vqv@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.