Re: [PATCH for-6.12-fixes] sched_ext: fix fmt__str variables in kfuncs

[Tejun Heo <tj@kernel.org>]

On Tue, Oct 22, 2024 at 09:40:35AM +0200, Andrea Righi wrote:
> Commit 3e99aee7ce48 ("sched-ext: Use correct annotation for strings in
> kfuncs") renamed some parameters without updating the body of the
> functions, triggering build errors like this:
> 
> kernel/sched/ext.c:6881:45: error: ‘fmt’ undeclared (first use in this function)
> 6881 |       if (bstr_format(&scx_exit_bstr_buf, fmt, data, data__sz) >= 0)
>      |                                             ^~~
> 
> Fix by renaming also the varibles in the affected kfuncs.
> 
> Fixes: 3e99aee7ce48 ("sched-ext: Use correct annotation for strings in kfuncs")
> Signed-off-by: Andrea Righi <andrea.righi@linux.dev>

I removed this patch along with 3e99aee7ce48 ("sched-ext: Use correct
annotation for strings in kfuncs"). This breaks compatibility in a way which
is difficult to work around. If we want to do this, I think we should do it
by introducing new set of kfuncs and than phasing out the old ones. Also,
it's unclear what the practical benefits of the change are anyway.

Thanks.

-- 
tejun