From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH] Introduce struct nftnl_str_array
Date: Wed, 23 Oct 2024 22:19:25 +0200 [thread overview]
Message-ID: <ZxlaTdMsvDDDD0Yg@orbyte.nwl.cc> (raw)
In-Reply-To: <20241023201304.GA29876@breakpoint.cc>
On Wed, Oct 23, 2024 at 10:13:04PM +0200, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > This data structure holds an array of allocated strings for use in
> > nftnl_chain and nftnl_flowtable structs. For convenience, implement
> > functions to clear, populate and iterate over contents.
> >
> > While at it, extend chain and flowtable tests to cover these attributes,
> > too.
> >
> > Signed-off-by: Phil Sutter <phil@nwl.cc>
> > ---
> > include/internal.h | 1 +
> > src/Makefile.am | 1 +
> > src/chain.c | 90 ++++++------------------------------
> > src/flowtable.c | 94 ++++++--------------------------------
> > src/utils.c | 1 +
> > tests/nft-chain-test.c | 37 ++++++++++++++-
> > tests/nft-flowtable-test.c | 21 +++++++++
> > 7 files changed, 86 insertions(+), 159 deletions(-)
>
> I don't see str_array.c here, missing 'git add'?
A classic. :(
V2 is underway.
Thanks, Phil
prev parent reply other threads:[~2024-10-23 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 20:00 [libnftnl PATCH] Introduce struct nftnl_str_array Phil Sutter
2024-10-23 20:13 ` Florian Westphal
2024-10-23 20:19 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxlaTdMsvDDDD0Yg@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.