Re: [PATCH] net/ixgbe: fix per-queue stats for less queues

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Oct 24, 2024 at 05:15:10PM +0200, Morten Brørup wrote:
> Forwarding to the now official maintainers for review. :-)
> 
> Thank you for updating the MAINTAINERS file, Bruce.
> 
> PS: Please correct "fix"->"support" in the subject when merging, it was a typo.
> 
> > From: Morten Brørup [mailto:mb@smartsharesystems.com]
> > Sent: Thursday, 24 October 2024 13.18
> > 
> > Remove the requirement that the configured number of queues to provide
> > statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the
> > driver's max supported number of the same (IXGBE_QUEUE_STAT_COUNTERS).
> > 
> > Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index ab37c37469..895d6e7169 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -3385,7 +3385,8 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev,
> > struct rte_eth_stats *stats)
> >  	stats->opackets = hw_stats->gptc;
> >  	stats->obytes = hw_stats->gotc;
> > 
> > -	for (i = 0; i < IXGBE_QUEUE_STAT_COUNTERS; i++) {
> > +	for (i = 0; i < RTE_MIN(IXGBE_QUEUE_STAT_COUNTERS,
> > +
> > 	(typeof(IXGBE_QUEUE_STAT_COUNTERS))RTE_ETHDEV_QUEUE_STAT_CNTRS);
> > i++) {

The big cast using "typeof" is awkward-looking but is probably the best way
to do this!

Thanks.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> >  		stats->q_ipackets[i] = hw_stats->qprc[i];
> >  		stats->q_opackets[i] = hw_stats->qptc[i];
> >  		stats->q_ibytes[i] = hw_stats->qbrc[i];
> > --
> > 2.43.0
>