From: Uladzislau Rezki <urezki@gmail.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: "Uladzislau Rezki (Sony)" <urezki@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
RCU <rcu@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Neeraj upadhyay <Neeraj.Upadhyay@amd.com>,
Boqun Feng <boqun.feng@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>
Subject: Re: [PATCH 2/2] rcuscale: Remove redundant WARN_ON_ONCE() splat
Date: Fri, 25 Oct 2024 11:33:03 +0200 [thread overview]
Message-ID: <Zxtlz8LeOs3l20c0@pc636> (raw)
In-Reply-To: <640af17a-958c-4321-89d4-8ab1f12986fb@paulmck-laptop>
On Thu, Oct 24, 2024 at 01:28:24PM -0700, Paul E. McKenney wrote:
> On Thu, Oct 24, 2024 at 06:45:58PM +0200, Uladzislau Rezki (Sony) wrote:
> > There are two places where WARN_ON_ONCE() is called two times
> > in the error paths. One which is encapsulated into if() condition
> > and another one, which is unnecessary, is placed in the brackets.
> >
> > Remove an extra WARN_ON_ONCE() splat which is in brackets.
> >
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
>
> For both:
>
> Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
>
Thank you :)
--
Uladzislau Rezki
next prev parent reply other threads:[~2024-10-25 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 16:45 [PATCH 1/2] rcuscale: Do a proper cleanup if kfree_scale_init() fails Uladzislau Rezki (Sony)
2024-10-24 16:45 ` [PATCH 2/2] rcuscale: Remove redundant WARN_ON_ONCE() splat Uladzislau Rezki (Sony)
2024-10-24 20:28 ` Paul E. McKenney
2024-10-25 9:33 ` Uladzislau Rezki [this message]
2024-10-28 16:07 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxtlz8LeOs3l20c0@pc636 \
--to=urezki@gmail.com \
--cc=Neeraj.Upadhyay@amd.com \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksiy.avramchenko@sony.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.