Re: qcrypto_ivgen mem leak and possible issue?

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Oct 25, 2024 at 01:06:01PM -0300, Matheus Tavares Bernardino wrote:
> Hi,
> 
> Since e3c07527f3 (crypto/hash: Implement and use new hash API,
> 2024-10-08), we've been seeing a memory leak in two check-unit tests:
> test-crypto-hash and test-crypto-ivgen. Looking a bit further to try and
> plug the leak, I got a bit confused regarding how the result crypto
> buffer is handled. Looks like we are allocating different sizes at two
> different places, and I'm unsure if these places follow the same
> convention or could be breaking expectations from one another...

There was a screwup in the commit you mention causing a memory leak. Can
you check whether it reproduces after

commit dde538c9a76f328a92c532893e97e18785d57364
Author: Daniel P. Berrangé <berrange@redhat.com>
Date:   Tue Oct 15 13:25:36 2024 +0100

    crypto/hash: avoid overwriting user supplied result pointer


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|