All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: Steven Sistare <steven.sistare@oracle.com>
Cc: <iommu@lists.linux.dev>, Jason Gunthorpe <jgg@nvidia.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH V7 9/9] iommufd: map file selftest
Date: Fri, 25 Oct 2024 11:39:40 -0700	[thread overview]
Message-ID: <Zxvl7J0mWkKPS4GD@Asurada-Nvidia> (raw)
In-Reply-To: <2c7edd3b-61c7-4012-b825-4972c0efcec5@oracle.com>

On Fri, Oct 25, 2024 at 01:58:57PM -0400, Steven Sistare wrote:
> On 10/25/2024 1:04 PM, Nicolin Chen wrote:
> > On Fri, Oct 25, 2024 at 06:11:59AM -0700, Steve Sistare wrote:
> > > 
> > > Add test cases to exercise IOMMU_IOAS_MAP_FILE.
> > > 
> > > Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> > > Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>

Reran on Jason's linus tree:
...
# PASSED: 204 / 204 tests passed.
# Totals: pass:194 fail:0 xfail:0 xpass:0 skip:10 error:0
...
# PASSED: 8 / 8 tests passed.
# Totals: pass:8 fail:0 xfail:0 xpass:0 skip:0 error:0

Tested-by: Nicolin Chen <nicolinc@nvidia.com>

> > The build passes, but I now see a few failing tests. Any idea?
> 
> Strange.  All tests pass for me, with patches applied to base commit
> e2d8fe9148b79ed1cbf0663edc988db7769173dc
> 
>   # modprobe iomufd
>   # iommufd
>   ...
>   Totals: pass:204 fail:0 xfail:0 xpass:0 skip:0 error:0
> 
> However, I also needed this patch from Yi Liu to make it work:
> [2] https://github.com/yiliu1765/iommufd/commit/ff0772d155c1ae2841e7b7ff0d7ca889271b81b2
> 
> Without that, most tests fail, even before my series.

I run on ARM64, so I don't have that for it fixing an x86 issue.

> I will try to reproduce your failures.
> What is your base commit?

I was using the for-next tree (rc1) from:
git git://git.kernel.org/pub/scm/linux/kernel/git/jgg/iommufd.git

And it was failing, so I guess rc1 is missing something for memfd.
So, it should be a false alarm.

> What is your value of /sys/kernel/mm/transparent_hugepage/shmem_enabled ?
>   (both always and never pass for me)

$ cat /sys/kernel/mm/transparent_hugepage/shmem_enabled
always within_size advise [never] deny force

And I retried with "always" that works too with the linus tree.

Thanks
Nicolin

  reply	other threads:[~2024-10-25 18:40 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25 13:11 [PATCH V7 0/9] iommu_ioas_map_file Steve Sistare
2024-10-25 13:11 ` [PATCH V7 1/9] mm/gup: folio_add_pins Steve Sistare
2024-10-25 13:11 ` [PATCH V7 2/9] iommufd: rename uptr in iopt_alloc_iova Steve Sistare
2024-10-25 13:11 ` [PATCH V7 3/9] iommufd: generalize iopt_pages address Steve Sistare
2024-10-25 13:11 ` [PATCH V7 4/9] iommufd: pfn reader local variables Steve Sistare
2024-10-25 13:11 ` [PATCH V7 5/9] iommufd: folio subroutines Steve Sistare
2024-10-25 13:11 ` [PATCH V7 6/9] iommufd: pfn reader for file mappings Steve Sistare
2024-10-31  3:34   ` Alexey Kardashevskiy
2024-11-06  3:18     ` Alexey Kardashevskiy
2024-11-06 13:19       ` Steven Sistare
2024-11-07 10:00         ` Alexey Kardashevskiy
2024-11-07 13:21           ` Steven Sistare
2024-11-07 14:08           ` Jason Gunthorpe
2024-11-08  0:01             ` Alexey Kardashevskiy
2024-11-14  4:03               ` Alexey Kardashevskiy
2024-11-14 16:17                 ` Jason Gunthorpe
2024-11-18  1:24                   ` Alexey Kardashevskiy
2024-10-25 13:11 ` [PATCH V7 7/9] iommufd: IOMMU_IOAS_MAP_FILE Steve Sistare
2024-10-25 13:11 ` [PATCH V7 8/9] iommufd: file mappings for mdev Steve Sistare
2024-10-25 13:11 ` [PATCH V7 9/9] iommufd: map file selftest Steve Sistare
2024-10-25 13:14   ` Steven Sistare
2024-10-25 17:00     ` Nicolin Chen
2024-10-25 17:04   ` Nicolin Chen
2024-10-25 17:58     ` Steven Sistare
2024-10-25 18:39       ` Nicolin Chen [this message]
2024-10-25 23:58         ` Jason Gunthorpe
2024-10-26 19:13           ` Steven Sistare
2024-10-26 19:16             ` Steven Sistare
2024-10-26 23:09               ` Nicolin Chen
2024-10-27 14:38                 ` Steven Sistare
2024-10-30  0:11 ` [PATCH V7 0/9] iommu_ioas_map_file Jason Gunthorpe
2024-10-30 12:43   ` Steven Sistare
2024-11-04 13:58     ` Steven Sistare
2024-11-04 14:18       ` Jason Gunthorpe
2024-11-04 14:24         ` Steven Sistare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zxvl7J0mWkKPS4GD@Asurada-Nvidia \
    --to=nicolinc@nvidia.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@nvidia.com \
    --cc=kevin.tian@intel.com \
    --cc=steven.sistare@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.