All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] tst_cgroup.c: Force tst_cg_scan only scan specific cgroup version if needs_ver exist
Date: Fri, 8 Nov 2024 10:53:11 +0100	[thread overview]
Message-ID: <Zy3fh5YZeJ5djPt3@yuki.lan> (raw)
In-Reply-To: <20241108053710.8639-1-wegao@suse.com>

Hi!
> tst_cgroup.c will scan cgroup mount point and check system's cgroup support status, both
> cgroupv1 and cgroupv2, if your case only need check cgroupv1(such as needs_cgroup_ver = TST_CG_V1)
> but your system contain cgroupv2 mount point, then TCONF will happen tell you your system already
> mount cgroupv2, so test case will be skipped.

I do not get what happens here. What is the exact test output that does
not work for you?

We have tst_cg_require() which attempts to mount either v1 or v2 as
described in options. However a controller can be mouted either in v1 or
v2 but not in both, so skipping the scan will not solve anything.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-11-08  9:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08  5:37 [LTP] [PATCH v1] tst_cgroup.c: Force tst_cg_scan only scan specific cgroup version if needs_ver exist Wei Gao via ltp
2024-11-08  9:53 ` Cyril Hrubis [this message]
2024-11-08 11:21   ` Wei Gao via ltp
2024-11-08 11:23     ` Cyril Hrubis
2024-11-11  2:47       ` Wei Gao via ltp
2024-11-11 12:08         ` Cyril Hrubis
     [not found]           ` <dnhjiv6iqwbref6kaq2amylqbwrksnph3l7ewxgqetp6crrz3s@3k5j5t4sy2gl>
2024-12-05 13:16             ` Cyril Hrubis
2024-12-09 11:25               ` Wei Gao via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zy3fh5YZeJ5djPt3@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=wegao@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.