From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "Tommaso Merciai" <tomm.merciai@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Paweł Anikiel" <panikiel@google.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: v4l2-subdev: Refactor events
Date: Tue, 29 Oct 2024 06:42:44 +0000 [thread overview]
Message-ID: <ZyCD5O7BjtvPbFw-@kekkonen.localdomain> (raw)
In-Reply-To: <20241028183657.GE26852@pendragon.ideasonboard.com>
On Mon, Oct 28, 2024 at 08:36:57PM +0200, Laurent Pinchart wrote:
> > > What I meant is looking at the I2C sensor drivers that currently
> > >
> > > - call v4l2_subdev_init_finalize()
> > > - set V4L2_SUBDEV_FL_HAS_EVENTS
> > > - set the .subscribe_event() and .unsubscribe_event() handlers
> > >
> > > and dropping the flag and handlers from them. Is that what you plan to
> > > work on ?
> >
> > It's ok for you per/driver patch or you prefer a big single patch?
>
> I'm fine either way. Maybe one large patch to address all the drivers
> where the flag and handlers are simply dropped, and then one patch per
> driver where changes are larger (such as adding calls to
> v4l2_subdev_init_finalize()) ?
Sounds good to me.
--
Sakari Ailus
next prev parent reply other threads:[~2024-10-29 6:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 16:35 [PATCH v2] media: v4l2-subdev: Refactor events Tommaso Merciai
2024-10-20 16:43 ` Laurent Pinchart
2024-10-21 6:35 ` Tommaso Merciai
2024-10-21 7:30 ` Laurent Pinchart
2024-10-21 8:12 ` Tommaso Merciai
2024-10-28 17:32 ` Tommaso Merciai
2024-10-28 18:36 ` Laurent Pinchart
2024-10-29 6:42 ` Sakari Ailus [this message]
2024-10-21 7:26 ` Sakari Ailus
2024-10-21 8:16 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyCD5O7BjtvPbFw-@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=panikiel@google.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.