All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Frediano Ziglio <frediano.ziglio@cloud.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v7 5/5] x86/boot: Clarify comment
Date: Tue, 29 Oct 2024 15:53:41 +0100	[thread overview]
Message-ID: <ZyD29aZqLRydMUCp@macbook> (raw)
In-Reply-To: <20241029102942.162912-6-frediano.ziglio@cloud.com>

On Tue, Oct 29, 2024 at 10:29:42AM +0000, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> ---
>  xen/arch/x86/boot/reloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c
> index e50e161b27..e725cfb6eb 100644
> --- a/xen/arch/x86/boot/reloc.c
> +++ b/xen/arch/x86/boot/reloc.c
> @@ -65,7 +65,7 @@ typedef struct memctx {
>      /*
>       * Simple bump allocator.
>       *
> -     * It starts from the base of the trampoline and allocates downwards.
> +     * It starts on top of space reserved for the trampoline and allocates downwards.

I'm afraid this line is over 80 characters long, will need to be
adjusted.  Maybe:

    * Starts at top of the relocated trampoline space and allocates downwards.

Thanks.


  reply	other threads:[~2024-10-29 14:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 10:29 [PATCH v7 0/5] Reuse 32 bit C code more safely Frediano Ziglio
2024-10-29 10:29 ` [PATCH v7 1/5] x86/boot: Rework how 32bit C is linked/included for early boot Frediano Ziglio
2024-10-29 15:09   ` Andrew Cooper
2024-10-29 10:29 ` [PATCH v7 2/5] x86/boot: Reuse code to relocate trampoline Frediano Ziglio
2024-10-29 10:29 ` [PATCH v7 3/5] x86/boot: Use boot_vid_info variable directly from C code Frediano Ziglio
2024-10-29 10:29 ` [PATCH v7 4/5] x86/boot: Use trampoline_phys " Frediano Ziglio
2024-10-29 10:29 ` [PATCH v7 5/5] x86/boot: Clarify comment Frediano Ziglio
2024-10-29 14:53   ` Roger Pau Monné [this message]
2024-10-29 15:07     ` Andrew Cooper
2024-10-29 16:40       ` Frediano Ziglio
2024-10-29 16:44         ` Alejandro Vallejo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZyD29aZqLRydMUCp@macbook \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=frediano.ziglio@cloud.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.