From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org,
xen-devel@lists.xenproject.org,
Natanael Copa <ncopa@alpinelinux.org>
Subject: Re: [Mini-OS PATCH] Add missing symbol exports for grub-pv
Date: Tue, 29 Oct 2024 12:50:13 +0100 [thread overview]
Message-ID: <ZyDL9fGtcouw9bar@begin> (raw)
In-Reply-To: <20241029114158.17231-1-jgross@suse.com>
Juergen Gross, le mar. 29 oct. 2024 12:41:58 +0100, a ecrit:
> Grub-pv needs start_info_union and phys_to_machine_mapping to be
> accessible. Export both symbols.
>
> Fixes: 33411a11f848 ("Mini-OS: hide all symbols not exported via EXPORT_SYMBOLS()")
> Reported-by: Natanael Copa <ncopa@alpinelinux.org>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> arch/x86/mm.c | 1 +
> arch/x86/setup.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/x86/mm.c b/arch/x86/mm.c
> index 572e762e..3ba6d917 100644
> --- a/arch/x86/mm.c
> +++ b/arch/x86/mm.c
> @@ -55,6 +55,7 @@
> #endif
>
> unsigned long *phys_to_machine_mapping;
> +EXPORT_SYMBOL(phys_to_machine_mapping);
> unsigned long mfn_zero;
> pgentry_t *pt_base;
> EXPORT_SYMBOL(pt_base);
> diff --git a/arch/x86/setup.c b/arch/x86/setup.c
> index b27bbed7..b613083b 100644
> --- a/arch/x86/setup.c
> +++ b/arch/x86/setup.c
> @@ -41,6 +41,7 @@
> * address of the shared_info structure, and things like that.
> */
> union start_info_union start_info_union;
> +EXPORT_SYMBOL(start_info_union);
> #endif
>
> /*
> --
> 2.43.0
next prev parent reply other threads:[~2024-10-29 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 11:41 [Mini-OS PATCH] Add missing symbol exports for grub-pv Juergen Gross
2024-10-29 11:50 ` Samuel Thibault [this message]
2024-10-29 12:01 ` Andrew Cooper
2024-10-29 12:02 ` Jürgen Groß
2024-10-29 12:13 ` Andrew Cooper
2024-10-29 12:17 ` Juergen Gross
2024-10-29 13:26 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyDL9fGtcouw9bar@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=jgross@suse.com \
--cc=minios-devel@lists.xenproject.org \
--cc=ncopa@alpinelinux.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.