From: Grant Peltier <grantpeltier93@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: robh@kernel.org, linux@roeck-us.net, magnus.damm@gmail.com,
grant.peltier.jg@renesas.com, brandon.howell.jg@renesas.com,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v5 0/2] dt-bindings: hwmon: pmbus: add bindings for isl68137
Date: Tue, 29 Oct 2024 11:32:53 -0500 [thread overview]
Message-ID: <ZyEONRFoooymFcfJ@raspberrypi> (raw)
In-Reply-To: <CAMuHMdWHZR9pN3h=Jdsqs5Qb0mi_4CobBtu82PRgzrm5TRgE4A@mail.gmail.com>
On Mon, Oct 28, 2024 at 11:18:39AM +0100, Geert Uytterhoeven wrote:
> > v4:
> > - Revert devicetree property name to "vout-voltage-divider" and refactor
> > property description and driver implementation to match existing
> > vout-voltage-divider implementation in max20730 as no suitable generic
> > voltage divider schema exists.
>
> Can you please elaborate (or point to the email that did so, in case
> I missed it)?
>
> In reply to v2, Günter wrote:
>
> "I would prefer, in the order of preference,
>
> 1) an applicable generic property definition
> 2) a definition that is already used elsewhere
> 3) a new chips specific definition"
>
> https://lore.kernel.org/all/3f460b62-4cd1-49dd-a98b-1fbcfdbd3af0@roeck-us.net
>
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
Hi Geert,
After looking through existing bindings definitions, the only generic
voltage divider property that I found was one that is intended to scale
voltages for IIO io-channels. However, the use case here is to scale
particular hwmon PMBus telemetry, which most closely matches the existing
implementation of the vout-voltage-divider property in the max20730
driver so I opted to copy that implementation based on Guenter's
preferences. Is there something that I missed or more information that
you are looking for?
Thanks,
Grant
next prev parent reply other threads:[~2024-10-29 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 17:16 [PATCH v5 0/2] dt-bindings: hwmon: pmbus: add bindings for isl68137 Grant Peltier
2024-10-25 17:16 ` [PATCH v5 1/2] hwmon: (pmbus/isl68137) add support for voltage divider on Vout Grant Peltier
2024-10-25 17:17 ` [PATCH v5 2/2] dt-bindings: hwmon: isl68137: add bindings to support voltage dividers Grant Peltier
2024-10-27 23:01 ` Rob Herring (Arm)
2024-10-28 10:18 ` [PATCH v5 0/2] dt-bindings: hwmon: pmbus: add bindings for isl68137 Geert Uytterhoeven
2024-10-29 16:32 ` Grant Peltier [this message]
2024-10-29 18:00 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyEONRFoooymFcfJ@raspberrypi \
--to=grantpeltier93@gmail.com \
--cc=brandon.howell.jg@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=grant.peltier.jg@renesas.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=magnus.damm@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.