From: Raag Jadav <raag.jadav@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>,
intel-gfx@lists.freedesktop.org, gustavo.sousa@intel.com
Subject: Re: [PATCH v3] drm/i915/xe3lpd: Power request asserting/deasserting
Date: Tue, 29 Oct 2024 19:02:45 +0200 [thread overview]
Message-ID: <ZyEVNW_OG0g8c0X-@black.fi.intel.com> (raw)
In-Reply-To: <87bjz3nf8m.fsf@intel.com>
On Tue, Oct 29, 2024 at 04:41:29PM +0200, Jani Nikula wrote:
> On Tue, 29 Oct 2024, Mika Kahola <mika.kahola@intel.com> wrote:
...
> > +static void wa_14020908590(struct intel_display *display,
> > + bool enable)
> > +{
> > + bool error = false;
> > +
> > + /* check if mailbox is running busy */
> > + if (intel_de_wait_for_clear(display, TCSS_DISP_MAILBOX_IN_CMD,
> > + TCSS_DISP_MAILBOX_IN_CMD_RUN_BUSY, 10)) {
> > + drm_dbg_kms(display->drm,
> > + "Timeout waiting for TCSS mailbox run/busy bit to clear\n");
>
> Just do drm_WARN() with the message here.
Rather,
ret = intel_de_wait_for_clear();
if (drm_WARN(drm, ret, ...))
return;
Cleaner?
Raag
next prev parent reply other threads:[~2024-10-29 17:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 14:00 [PATCH v3] drm/i915/xe3lpd: Power request asserting/deasserting Mika Kahola
2024-10-29 14:41 ` Jani Nikula
2024-10-29 17:02 ` Raag Jadav [this message]
2024-10-30 11:22 ` Kahola, Mika
2024-10-30 11:36 ` Raag Jadav
2024-10-29 16:56 ` Raag Jadav
2024-10-29 17:18 ` Gustavo Sousa
2024-10-30 11:23 ` Kahola, Mika
2024-10-29 21:23 ` ✓ Fi.CI.BAT: success for drm/i915/xe3lpd: Power request asserting/deasserting (rev2) Patchwork
2024-10-29 21:25 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-10-30 17:01 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyEVNW_OG0g8c0X-@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=gustavo.sousa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.