All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Edgar Bonet <bonet@grenoble.cnrs.fr>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Buildroot Development <buildroot@buildroot.org>,
	Brandon Maier <brandon.maier@collins.com>,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Ben Wolsieffer <Ben.Wolsieffer@hefring.com>
Subject: Re: [Buildroot] [PATCH] package/git: fix wchar-less uclibc build
Date: Wed, 30 Oct 2024 16:55:30 +0700	[thread overview]
Message-ID: <ZyICku0zbnvGpGB9@archie.me> (raw)
In-Reply-To: <321d4dd3-10ad-48df-8155-27bd529c590d@grenoble.cnrs.fr>


[-- Attachment #1.1: Type: text/plain, Size: 657 bytes --]

On Mon, Oct 28, 2024 at 11:39:49PM +0100, Edgar Bonet wrote:
> Hello!
> 
> Bagas Sanjaya wrote:
> > +Fix the build failure by only using wchar_t when __UCLIBC_HAS_WCHAR__
> > +is actually defined.
> 
> Thomas Petazzoni replied:
> > The solution isn't really nice, because it adds some uClibc specific
> > logic.
> 
> Indeed. Note, however, that the patch is making its way upstream:
> 
>     https://lore.kernel.org/git/cover.1729506329.git.ps@pks.im/T/#u
> 
> (long thread, search for “uClibc” to see the relevant bits).

OK, I will pull from upstream instead.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-10-30  9:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-20  9:25 [Buildroot] [PATCH] package/git: fix wchar-less uclibc build Bagas Sanjaya
2024-10-28 22:13 ` Thomas Petazzoni via buildroot
2024-10-28 22:39   ` Edgar Bonet
2024-10-30  9:55     ` Bagas Sanjaya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZyICku0zbnvGpGB9@archie.me \
    --to=bagasdotme@gmail.com \
    --cc=Ben.Wolsieffer@hefring.com \
    --cc=bonet@grenoble.cnrs.fr \
    --cc=brandon.maier@collins.com \
    --cc=buildroot@buildroot.org \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.