From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 501061E411D for ; Wed, 30 Oct 2024 14:25:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730298309; cv=none; b=jLp0wGXFRSReOcKPOY4ZE7XoDlPn1kioDxnPZlFdIHrnnszVF1/MnuW9tt03izJ//drpuPRrYUQholnX/sxvERmd+2RVE+k0OXL871LJ38E9eCAms9UjW8QfYHURs2pB5Em1sPVs8oLYulFaYsy/s0DMlXZ6tBgAU3LK2XCCAXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730298309; c=relaxed/simple; bh=4Gp7d75aWXNfRjmVO52nxA3QXU5ih7LwQbhiSiPc9iw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=uiCGGs7SzA8qnIhzGyobbhAvl3sacB2Ntb8dbC1VkQQ2sjxUAfKhQ/fs6f1BIwJfuIWMGuJr+DVibFfcLU7gVi6SeXBQ9eIgjQqWUJj799wUk1X07VJAL7aXDIOmHrMTpGBKZDzes6jXb3kUKXDTL+Bmp4jnNdEv3ThF3fxSp8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GvF85vPJ; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GvF85vPJ" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-71e69e06994so8634452b3a.3 for ; Wed, 30 Oct 2024 07:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730298307; x=1730903107; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Uu9T/ChYAhKXym5Mb4uVCAro45E0RQzqAj0ht4HK0XM=; b=GvF85vPJlXvIxpiFUd3tKf+TX54FRrZTBNEUAAu827zIVlTNN+zu8W+ylDmzxK2irC l3qE0bddAKc9sLZ4XuDK0iWaT2S4wnhznHCvRHASstCVdjmVnUvWr+dzPitZaRXHIaLg ATH+ZFKhYVlx3Mr20laOH45hTiQgLh+nPuafcx5pW0D0YWwYSR3pvG21XkNe680a/lPl wRBKEqRO7AyZD9/hY/xHD/jKVMgMItHpstP0q01Qa23K6vSDsKDIyz+kVNvankaaOP33 aOAyl0O71HONgtwvxPIpto3Z0Fd8w0AqCjXPUxzps3mXyv2sjno2mqrZhuCqTuPygCdV T7MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730298307; x=1730903107; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Uu9T/ChYAhKXym5Mb4uVCAro45E0RQzqAj0ht4HK0XM=; b=MEXP3eob9Gt2Tv5gbRIeNrqZcK0k0knDYHmQd0zCxnC6fINEqdB/sKN4ltn/gDUiWJ cPeFLKzj1J2AGzyqmwf3MHBIMX+BtjOvxya234P3ljsYhM4mJxDwCyheCrbMdymUhjLV kPV3Dm6I2agscNCjMix+UecJnHQMQV8SQ+0ALHIZd14J1WZ9rPbpk+uX3kXf0N/fUNE3 kYx0LdQnsRTLL3T0bXRk3RauIjvWiMOaOSlMI6zXNnjr5taNafGGZGEv+6dhVzaJKsxQ iELIO5gu4f/Fecl0EBTh8dzP16t7eAGKhssps0LU75n9fu9lOpMvdFBin2gLGzhUwRQl QPHA== X-Forwarded-Encrypted: i=1; AJvYcCXHjA22XPWdjansZabS5LI8ssSX5btCQf4sjNuachddxuA24YvLnjKZ0Pc66JmAiXhQIhQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzC6+JJhrpJFXNOPQ7ApeMyrolLF2XY4u5hgMcknyEnOhv2LaVk Qi/6lKJrRzjlkGiOtqtejzFUeeoFIJZIazQ94AAyx/qwwkIEBLSAJSpZVm4150MVZIfOX/5y2IF 1rA== X-Google-Smtp-Source: AGHT+IE6Qy/01yhSfd29fTCsUG31avheDCycvCS+iPE1pjQUQ+FnkGoAp6kZbn5B9mvP+ij9etCUOSfsPC0= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a05:6a00:6014:b0:71e:5a0e:78d5 with SMTP id d2e1a72fcca58-720630ea7f4mr28714b3a.5.1730298306536; Wed, 30 Oct 2024 07:25:06 -0700 (PDT) Date: Wed, 30 Oct 2024 07:25:05 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240906204515.3276696-1-vipinsh@google.com> <20240906204515.3276696-2-vipinsh@google.com> Message-ID: Subject: Re: [PATCH v3 1/2] KVM: x86/mmu: Track TDP MMU NX huge pages separately From: Sean Christopherson To: Vipin Sharma Cc: pbonzini@redhat.com, dmatlack@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Wed, Oct 30, 2024, Sean Christopherson wrote: > On Fri, Sep 06, 2024, Vipin Sharma wrote: > > + struct list_head tdp_mmu_possible_nx_huge_pages; > > + u64 tdp_mmu_nr_possible_nx_huge_pages; > > These obviously come in a pair, and must be passed around as such. To make the > relevant code easier on the eyes (long lines), and to avoid passing a mismatched > pair, add a parent structure. > > E.g. > > struct kvm_possible_nx_huge_pages { > struct list_head list; Actually, I vote for s/list/pages, as that makes the usage in code is more intuitive. > u64 nr_pages; > }