From: Frederic Weisbecker <frederic@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel test robot <oliver.sang@intel.com>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: timers: Add missing READ_ONCE() in __run_timer_base()
Date: Thu, 31 Oct 2024 10:44:35 +0100 [thread overview]
Message-ID: <ZyNRg/fAJKY2h9ql@lothringen> (raw)
In-Reply-To: <87a5emyqk0.ffs@tglx>
On Wed, Oct 30, 2024 at 08:53:51AM +0100, Thomas Gleixner wrote:
> __run_timer_base() checks base::next_expiry without holding
> base::lock. That can race with a remote CPU updating next_expiry under the
> lock. This is an intentional and harmless data race, but lacks a
> READ_ONCE(), so KCSAN complains about this.
>
> Add the missing READ_ONCE(). All other places are covered already.
>
> Fixes: 79f8b28e85f8 ("timers: Annotate possible non critical data race of next_expiry")
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Closes: https://lore.kernel.org/oe-lkp/202410301205.ef8e9743-lkp@intel.com
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
next prev parent reply other threads:[~2024-10-31 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 5:38 [linus:master] [timers] fe90c5ba88: BUG:KCSAN:data-race_in_timer_expire_remote/timer_recalc_next_expiry kernel test robot
2024-10-30 7:53 ` timers: Add missing READ_ONCE() in __run_timer_base() Thomas Gleixner
2024-10-31 9:44 ` Frederic Weisbecker [this message]
2024-10-31 10:54 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyNRg/fAJKY2h9ql@lothringen \
--to=frederic@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.