All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: selftests: Don't force -march=x86-64-v2 if it's unsupported
Date: Thu, 31 Oct 2024 10:07:49 -0700	[thread overview]
Message-ID: <ZyO5ZUb8Acp80Ygq@google.com> (raw)
In-Reply-To: <87froctrgv.fsf@redhat.com>

On Thu, Oct 31, 2024, Vitaly Kuznetsov wrote:
> > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
> > index 156fbfae940f..5fa282643cff 100644
> > --- a/tools/testing/selftests/kvm/Makefile
> > +++ b/tools/testing/selftests/kvm/Makefile
> > @@ -249,8 +249,10 @@ ifeq ($(ARCH),s390)
> >  	CFLAGS += -march=z10
> >  endif
> >  ifeq ($(ARCH),x86)
> > +ifeq ($(shell echo "void foo(void) { }" | $(CC) -march=x86-64-v2 -x c - -c -o /dev/null 2>/dev/null; echo "$$?"),0)
> 
> With this test, the outer "ifeq ($(ARCH),x86)" check is not really
> needed anymore I guess?

Yeah, but at this point in the v6.12 cycle, I want to do the absolute bare minimum.
In 6.13, after the AVX support lands, I think we can/should revert this restriction,
i.e. it's a short-term wart.

  reply	other threads:[~2024-10-31 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31  4:53 [PATCH] KVM: selftests: Don't force -march=x86-64-v2 if it's unsupported Sean Christopherson
2024-10-31 11:57 ` Vitaly Kuznetsov
2024-10-31 17:07   ` Sean Christopherson [this message]
2024-11-05  5:56 ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZyO5ZUb8Acp80Ygq@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.