From: Raag Jadav <raag.jadav@intel.com>
To: "Kahola, Mika" <mika.kahola@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Sousa, Gustavo" <gustavo.sousa@intel.com>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>
Subject: Re: [PATCH v3 1/2] drm/i915/xe3lpd: Power request asserting/deasserting
Date: Thu, 31 Oct 2024 17:12:53 +0200 [thread overview]
Message-ID: <ZyOedbhfZlSldnaZ@black.fi.intel.com> (raw)
In-Reply-To: <ZyOZJ-hDIpT7G91_@black.fi.intel.com>
On Thu, Oct 31, 2024 at 04:50:20PM +0200, Raag Jadav wrote:
> On Thu, Oct 31, 2024 at 07:59:16PM +0530, Kahola, Mika wrote:
>
> ...
>
> > > > +static void wa_14020908590(struct intel_display *display,
> > > > + bool enable)
> > >
> > > Can be one line?
> >
> > Could be. This should fit within expected line length.
>
> With that,
>
> Reviewed-by: Raag Jadav <raag.jadav@intel.com>
Btw, this looks like a v4 with missing changelogs.
So make sure to update it too.
Raag
next prev parent reply other threads:[~2024-10-31 15:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 11:40 [PATCH v3 0/2] drm/i915/display: Power request asserting/deasserting Mika Kahola
2024-10-31 11:40 ` [PATCH v3 1/2] drm/i915/xe3lpd: " Mika Kahola
2024-10-31 12:55 ` Raag Jadav
2024-10-31 14:29 ` Kahola, Mika
2024-10-31 14:50 ` Raag Jadav
2024-10-31 15:12 ` Raag Jadav [this message]
2024-11-01 11:47 ` Kahola, Mika
2024-10-31 11:40 ` [PATCH v3 2/2] drm/i915/display: Use struct intel_display instead of struct drm_i915_private Mika Kahola
2024-10-31 12:50 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Power request asserting/deasserting Patchwork
2024-10-31 12:50 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-10-31 12:59 ` [PATCH v3 0/2] " Raag Jadav
2024-10-31 14:28 ` Kahola, Mika
2024-10-31 14:55 ` Raag Jadav
2024-10-31 14:04 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyOedbhfZlSldnaZ@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=gustavo.sousa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.