From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 680A5E67493 for ; Fri, 1 Nov 2024 02:37:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6hWc-0003kJ-8B; Thu, 31 Oct 2024 22:36:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6hWY-0003k4-4K for qemu-devel@nongnu.org; Thu, 31 Oct 2024 22:36:31 -0400 Received: from mgamail.intel.com ([192.198.163.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6hWR-0006U5-Hq for qemu-devel@nongnu.org; Thu, 31 Oct 2024 22:36:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730428583; x=1761964583; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oyqqdzEzzaRkh4CKa83T/wDIvOinbaPxWRO2/2V0FlY=; b=TC5PjJQa1msLe3ggKkmpEJvy4lNGsgAgyi4BWWkusN6zZf8MAxQTfMh7 D3b8CcBY/7KaSXopRcv9qMdfuiubKcOyirY4iK1zaJ8Sm0Z1veG9eJYCb P6yZoT1oKivFeQ3GMPtiw6JGLX/VHYQBszu8/ISJ0UORfhfnvxvHbEBjd IQPPfmUIqoSezopJSPOaA9NFuDL5v6l6HFw+IoBHjljRzK4gUrM/97gX3 3BsNCVFg7c36iC9jcq4ivaoW8WRgIvAGnW6JRv/m4An3imh6o2k0inKHA 31aW7lRuvDXG9x7AN0K+nkHRkOSfLqSmLe59q/OwT6qqOB+kpv5ZqIUus A==; X-CSE-ConnectionGUID: vF3oghkNQaKbLlSxUrt7bg== X-CSE-MsgGUID: cMBwD+/PR52PZttxV22KNA== X-IronPort-AV: E=McAfee;i="6700,10204,11242"; a="34126875" X-IronPort-AV: E=Sophos;i="6.11,248,1725346800"; d="scan'208";a="34126875" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2024 19:36:20 -0700 X-CSE-ConnectionGUID: mKzLAeDjQ2Wt0wQ2MsRetw== X-CSE-MsgGUID: hd2X4rd6SOSStsXvEI4olw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,248,1725346800"; d="scan'208";a="83260128" Received: from linux.bj.intel.com ([10.238.157.71]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2024 19:36:19 -0700 Date: Fri, 1 Nov 2024 10:31:12 +0800 From: Tao Su To: Zhao Liu Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, mtosatti@redhat.com, xiaoyao.li@intel.com, xuelian.guo@intel.com Subject: Re: [PATCH v3 4/8] target/i386: add AVX10 feature and AVX10 version property Message-ID: References: <20241031085233.425388-1-tao1.su@linux.intel.com> <20241031085233.425388-5-tao1.su@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: none client-ip=192.198.163.12; envelope-from=tao1.su@linux.intel.com; helo=mgamail.intel.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.366, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Nov 01, 2024 at 10:44:23AM +0800, Zhao Liu wrote: > > > prefix is just used to print warning. So here we should check prefix > > > for warn_report. > > > > > > + } else if (env->avx10_version) { > > > + if (prefix) { > > > + warn_report("%s: avx10.%d.", prefix, env->avx10_version); > > > + } > > > + have_filtered_features = true; > > > + } > > > > > > > Yes, thanks for pointing out! But I see this patch set is already pulled, > > not sure whether it is easy to change... > > I will soon have another clean-up series, and I can include this part. > You can send me your patch, or I can help you with it. Please help me do that, thanks! :-)