All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] rev-list: skip bitmap traversal for --left-right
Date: Fri, 1 Nov 2024 10:40:41 -0400	[thread overview]
Message-ID: <ZyToaRxR7upLg0IE@nand.local> (raw)
In-Reply-To: <20241101121606.GA2327410@coredump.intra.peff.net>

On Fri, Nov 01, 2024 at 08:16:06AM -0400, Jeff King wrote:
>  builtin/rev-list.c      |  7 +++++++
>  t/t5310-pack-bitmaps.sh | 12 ++++++++++++
>  2 files changed, 19 insertions(+)

Nice find, and well explained (not just why it doesn't work today but
could in the future, but why making it work in the future with bitmaps
does not necessarily a clear performance improvement).

Probably you and I should think more about other rev-list options that
*don't* work with --use-bitmap-index. I share your feeling there that
there probably exist such options which silently do nothing (or the
wrong thing) in the presence of '--use-bitmap-index'.

Let's merge this one down.

Thanks,
Taylor

  reply	other threads:[~2024-11-01 14:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-01 12:16 [PATCH] rev-list: skip bitmap traversal for --left-right Jeff King
2024-11-01 14:40 ` Taylor Blau [this message]
2024-11-04 17:41   ` Jeff King
2024-11-04 17:46     ` Jeff King
2024-11-04 18:34       ` Taylor Blau
2025-02-02 12:28         ` Ayush Chandekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZyToaRxR7upLg0IE@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.