From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Fri, 1 Nov 2024 09:31:05 -0700 Subject: [PATCH v3 03/14] KVM: selftests: Return a value from vcpu_get_reg() instead of using an out-param In-Reply-To: References: <20241009154953.1073471-1-seanjc@google.com> <20241009154953.1073471-4-seanjc@google.com> <39ea24d8-9dae-447a-ae37-e65878c3806f@sirena.org.uk> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Nov 01, 2024, Oliver Upton wrote: > On Fri, Nov 01, 2024 at 09:16:42AM -0700, Sean Christopherson wrote: > > One thing I'll add to my workflow would be to do a local merge (and smoke test) > > of linux-next into kvm-x86 next before pushing it out. This isn't the only snafu > > this cycle where such a sanity check would have saved me and others a bit of pain. > > Eh, shit happens, that's what -next is for :) Heh, but I also don't actually test -next, which was another snafu (not my fault this time!) from this cycle[*]. Testing 6.12-next prior to the merge window wouldn't have made that any less painful to bisect, but I think it would at least have allowed me to detect that the issue specifically came in from linux-next, and the bug report would have gotten to PeterZ almost two months earlier. https://lore.kernel.org/all/ZwdA0sbA2tJA3IKh at google.com From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FB08381BA for ; Fri, 1 Nov 2024 16:31:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730478670; cv=none; b=KeqkZ8/nPoD3yLAy8VjLW7kjvvNYHuvORzE6scmAQu/E1z+AJMjz683VpHpLiTnLlMZUAF4pRbWCsTwSV3vLNly+1tTcrstC6pfkhiCplF9bLQgLBiKWyS8oCiU/hH0mWjV0dQ4e+8WA30RShHUsKPCfeuIcvjVNaCxeSgYCV8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730478670; c=relaxed/simple; bh=aCYFBS0OlRXeeN66mv6hk1AzePNNwIISd3kE5LOhZGM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=IF6/XRgnef5V8HICXxT4j6cOo7Ju03ftdAv1afW8m3hqU+giJrUGdyT44IJ2dFsHtVLUhnrQSFFQwyj9luNr85/aPqLGUbqOAkEswxUtY3ARvVDX/09n2xHx6UH9XcYqdYRBxTGKq7OlrB0ueIVqXjWZC8wQXKBjBxwamc7P7jE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=3LJ3da5+; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="3LJ3da5+" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e29135d1d0cso3855308276.1 for ; Fri, 01 Nov 2024 09:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730478667; x=1731083467; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QUMHVY5Pc5ujaPIETtg1OV7OoMZH/DlrlEhMasUvFWg=; b=3LJ3da5+VnMSMaOJVtGnkKbXVzQSvLW4o0hHbA7OILbUweL6kiiES6TLw56gaunJ6Q 6Z1nyKTyIp06u+BlLB3ykq8nfFeffsPGNOl0rAZ8fCxaCYxkBrvTbxWL+GfgBaZajHYo wjA1vXy3w8qMgvr7/fBmUiiKM7nTh2xqdYMsMHkw1o1Z2+D7bOnyySPtGN1qfxUWFyyZ 6DTOv5G+cYcIyCDs4+ij8iRQRFIE7lLtrBeD7UFfkJSKNUGvZ3YhAgM3oVPLWkQW4Hrr 5rern56Tas03NIu0YpGpDDLacjUyfhCoIE06Z05fGwNJAnLOQXYZzKJmk+D2ZiT6FGKk zl0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730478667; x=1731083467; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QUMHVY5Pc5ujaPIETtg1OV7OoMZH/DlrlEhMasUvFWg=; b=Xbn0XPLuCHToMhbbdhgbjtmzd8O49Z/7ictH0ILPch60z0FAzk4cPfEch+YYOVzM6X mknRvSLOZ687MZPZ0D4637IANEeaix9P6S5G3D1M1/OGXSVi7YgPMg76/zlKDkv80CaZ I91hJ3aQsgiVVFDZ/oD3TDsps8JnssEZqFhraGxttbS1RSJxUD3ztQbu5++q5ElJ908t je6CRACWrE3YLTKA0WNBNQSInhOfNc9tlsbhG/zuf6/z4gPgiS1ZwGBWYf8ssh8evSCA Qzd3nNO08cE2ObM32Vc9YnMOnyc5n7PZIkctWukctHE7fvjdj9t2cnUgwDSA14qXUZuA 4GUw== X-Forwarded-Encrypted: i=1; AJvYcCV2g71Bg/cGPJmSaLDVDzGiGrgWt2qHTGkhuYRUIFu4Bw8amhFJupMW/ZiXmAtIXhL/QCQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzl17nGNjlQnxj5NQpKofKPqO9WSX5UmRVFe5t2ISq30FymjWRq NkgtqlbbDTFA0XStWKKg4mIoOEifsncp/psBITqAdBPG/u1Df/meEorhpZJkqR0d3OLP+NpKN29 8QQ== X-Google-Smtp-Source: AGHT+IHjSky3TikiN5BvrlqT+n0lNdXJaonGgodvNxJp+r7LiGTo8fiUiA/fuWajhuo5hdeSs5DxJ2eOWac= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a25:c8c6:0:b0:e33:111b:c6a4 with SMTP id 3f1490d57ef6-e33111bc836mr1008276.1.1730478667415; Fri, 01 Nov 2024 09:31:07 -0700 (PDT) Date: Fri, 1 Nov 2024 09:31:05 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241009154953.1073471-1-seanjc@google.com> <20241009154953.1073471-4-seanjc@google.com> <39ea24d8-9dae-447a-ae37-e65878c3806f@sirena.org.uk> Message-ID: Subject: Re: [PATCH v3 03/14] KVM: selftests: Return a value from vcpu_get_reg() instead of using an out-param From: Sean Christopherson To: Oliver Upton Cc: Mark Brown , Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Paolo Bonzini , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jones , James Houghton , David Woodhouse , linux-next@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Fri, Nov 01, 2024, Oliver Upton wrote: > On Fri, Nov 01, 2024 at 09:16:42AM -0700, Sean Christopherson wrote: > > One thing I'll add to my workflow would be to do a local merge (and smoke test) > > of linux-next into kvm-x86 next before pushing it out. This isn't the only snafu > > this cycle where such a sanity check would have saved me and others a bit of pain. > > Eh, shit happens, that's what -next is for :) Heh, but I also don't actually test -next, which was another snafu (not my fault this time!) from this cycle[*]. Testing 6.12-next prior to the merge window wouldn't have made that any less painful to bisect, but I think it would at least have allowed me to detect that the issue specifically came in from linux-next, and the bug report would have gotten to PeterZ almost two months earlier. https://lore.kernel.org/all/ZwdA0sbA2tJA3IKh@google.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5626DE6F06C for ; Fri, 1 Nov 2024 16:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=JBos5Ka8mjyMqv20R+dBiXBCkwLt/+17PoyTGQ80cJs=; b=1RpSpFaVf/z7d6p2mauJq4wQ2y 8D3tXpYV+Ar2hUVFQofxTEggh9C78CfFkXNyRjH0xonnYjWiwS81+bUOXUa5QD6V5BxtqRe0nNFpO CSrHH3ZQlW92iyglH92crpYps9NbVbePAz0L4+yBAsGoAXEsnV1weRheL4qwEgQfF0TMQ++zT0Jaj MoHhHfnavBuuWU6AFGvLkPm1vbnT0oc3CYSDcQOlj/FkbWexEDBsfeTwPrwiIJkzOplAF3/VmD1hK oveog7ca8cMIeYwRkkg7YWqsyjRzmalF/YCPYoU3H6U4UjARiZqb7TgbLbTE67iMbmdnMwX4KMlEO EewyLdTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6ua3-00000007gsF-0IEn; Fri, 01 Nov 2024 16:32:59 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6uYO-00000007gXO-3Slz for linux-riscv@bombadil.infradead.org; Fri, 01 Nov 2024 16:31:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Cc:To:From:Subject: Message-ID:References:Mime-Version:In-Reply-To:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QUMHVY5Pc5ujaPIETtg1OV7OoMZH/DlrlEhMasUvFWg=; b=A9DqY2yKQeXaUtIAf2pqlUTovj OnojkQWEmzJ1FYHtR/JSsUoSON6885IF3boqmcs1PLEQvejjsqTh03bipDScQGy2jlZWGcXCYKUAR goC8F+KYxW3IXdMoBt7/vw7EdXIL/jc/ZGHUs1/28FHrn5uOw6sJqWA99m8AYdvoC+J74BykwswO3 ZR/2EOtjR4JoAXGyUWEt1571Atkwv0Mwi8bo/YuELQUQ/K2e62h5XcJsqDx64WcUsjArf3DmDtFCg zphVAjC7t5+ils8HzQ2XdhK5Pi8waidaOjbtOOKjQ1whxUoXMPgflWu1B1HzqrxnQ7Zdqle87HLi6 XjYL5D9w==; Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6uYK-0000000Alfu-01GI for linux-riscv@lists.infradead.org; Fri, 01 Nov 2024 16:31:15 +0000 Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-e290b8b69f8so4100985276.2 for ; Fri, 01 Nov 2024 09:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730478667; x=1731083467; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QUMHVY5Pc5ujaPIETtg1OV7OoMZH/DlrlEhMasUvFWg=; b=n/aFlmQpNNRbEryVz5u4+GUhf5FpeKIVwPDl7Nb6bwKu6fzwlWcOyDqqpUZ9O42u9m jTBwU/ATSQjXhY8ASscxKI9mXi1bW6+A1odgWWAyR8Mv8oB51I7p6ZpT53bT0EFllmwb vkagnvsWBZ75ryj6Yru9P+yhnGb9LXeZXPmKxMFcfwRbWTv7Vv8trv9TN5jHCoGw4hVS 45v8kHs5HnmppldLXN09mfdfasqE8JYFLUmcZ7IMi3LvyWviEVCSikGheMLWS4myaeQZ ljKtnc16fJ4wEwiZcNr3P/nsyxR1ySUERDBljorfTdl/LqDzebtXo3KEjJ+pBsY42cg8 Prbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730478667; x=1731083467; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QUMHVY5Pc5ujaPIETtg1OV7OoMZH/DlrlEhMasUvFWg=; b=qoniqd61QYalN2z0i9ibcZnRHOXatk0uFJTYhQ8TV2see0BnOrm8FSVf/E6ypgctDA nsLH6ckuh32vGR2Rs6EATi9O0LqgvStWjk4Uk5BC26RSzg8z5PR9TEl5jnhu4iIH0hjg npc+dXCsCwTUPAP7J4z+bie/PxaRSNa3OZyNnOEXvdexBk5Hzqur6I5qWhVeV5aPjW5w m/FCKX5Ynb/lyyMv7MiHSdPAI9PPVj2LutgRTkr+CpR758ZHnMKjh3ShrTcB0TpBo3NU DSghhbC34wumtJb/y3xA54tEOmDQqXWbZYzmsx8MzgphSW/Z/anV8bx1TfCnCiIYx16t +TnA== X-Forwarded-Encrypted: i=1; AJvYcCV+Pg4kNOF2+8LMlcCLTEFs2TH31hpTmh4U443lgZtRxRibWYScZkR7edqKNSTdKD1WRqpgxedieYY0jQ==@lists.infradead.org X-Gm-Message-State: AOJu0YzcMnWFCfC4Fn4PX0zzkJ8jb9WZXJ5av8Ou4bhSWQ7yoi8MffWK 2fCvrcr+ybLhszpg8fWAidysFsV1rG4WdHkjEN51ClbejCOgC2lPy17FpD8ArKFDCRk7a5qRnRL iFg== X-Google-Smtp-Source: AGHT+IHjSky3TikiN5BvrlqT+n0lNdXJaonGgodvNxJp+r7LiGTo8fiUiA/fuWajhuo5hdeSs5DxJ2eOWac= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a25:c8c6:0:b0:e33:111b:c6a4 with SMTP id 3f1490d57ef6-e33111bc836mr1008276.1.1730478667415; Fri, 01 Nov 2024 09:31:07 -0700 (PDT) Date: Fri, 1 Nov 2024 09:31:05 -0700 In-Reply-To: Mime-Version: 1.0 References: <20241009154953.1073471-1-seanjc@google.com> <20241009154953.1073471-4-seanjc@google.com> <39ea24d8-9dae-447a-ae37-e65878c3806f@sirena.org.uk> Message-ID: Subject: Re: [PATCH v3 03/14] KVM: selftests: Return a value from vcpu_get_reg() instead of using an out-param From: Sean Christopherson To: Oliver Upton Cc: Mark Brown , Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Paolo Bonzini , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jones , James Houghton , David Woodhouse , linux-next@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241101_163112_159222_8BC9C987 X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Nov 01, 2024, Oliver Upton wrote: > On Fri, Nov 01, 2024 at 09:16:42AM -0700, Sean Christopherson wrote: > > One thing I'll add to my workflow would be to do a local merge (and smoke test) > > of linux-next into kvm-x86 next before pushing it out. This isn't the only snafu > > this cycle where such a sanity check would have saved me and others a bit of pain. > > Eh, shit happens, that's what -next is for :) Heh, but I also don't actually test -next, which was another snafu (not my fault this time!) from this cycle[*]. Testing 6.12-next prior to the merge window wouldn't have made that any less painful to bisect, but I think it would at least have allowed me to detect that the issue specifically came in from linux-next, and the bug report would have gotten to PeterZ almost two months earlier. https://lore.kernel.org/all/ZwdA0sbA2tJA3IKh@google.com _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv