From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Benjamin Peterson <benjamin@engflow.com>
Cc: Howard Chu <howardchu95@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
"open list:PERFORMANCE EVENTS SUBSYSTEM"
<linux-perf-users@vger.kernel.org>,
"open list:PERFORMANCE EVENTS SUBSYSTEM"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] perf trace: avoid garbage when not printing a trace event's arguments
Date: Fri, 1 Nov 2024 21:38:03 -0300 [thread overview]
Message-ID: <ZyV0a6e_46R9pmQw@x1> (raw)
In-Reply-To: <CAEmfU+ufKWoJLvhksPzADMKkbinV37Tv1KODU6RdJfBM9Juy7w@mail.gmail.com>
On Fri, Nov 01, 2024 at 02:41:46PM -0700, Benjamin Peterson wrote:
> On Fri, Nov 1, 2024 at 2:30 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > I haven't tested it yet, just in my mind :-)
> > The patch looks ok and seems to fix a real problem, my only concern, a
> > pet peeve, was that it, in addition to fixing a real problem, did an
> > unrelated change, the "Remove the return value...", that part looks like
> > a distraction, something that shouldn't be there.
> In my mind, it was related because both the bug and the odd return
> value arise from incorrect counting of the number of written bytes.
> Obviously, the fix is what I care about, so feel free to strip out the
> return value change on import, or I can resend.
The point is to try to focus on the fix, and do just what is needed for
that. Everything else ends up being a distraction.
- Arnaldo
next prev parent reply other threads:[~2024-11-02 0:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 0:53 [PATCH] perf trace: avoid garbage when not printing an trace event's arguments Benjamin Peterson
2024-11-01 2:03 ` Howard Chu
2024-11-01 17:26 ` Benjamin Peterson
2024-11-01 17:27 ` [PATCH v2] perf trace: avoid garbage when not printing a " Benjamin Peterson
2024-11-01 21:00 ` Howard Chu
2024-11-01 21:30 ` Arnaldo Carvalho de Melo
2024-11-01 21:41 ` Benjamin Peterson
2024-11-02 0:38 ` Arnaldo Carvalho de Melo [this message]
2024-11-03 20:48 ` [PATCH v3] " Benjamin Peterson
2024-11-05 18:52 ` Arnaldo Carvalho de Melo
2024-11-06 17:03 ` Namhyung Kim
2024-11-03 4:54 ` [PATCH] perf trace: avoid garbage when not printing an " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyV0a6e_46R9pmQw@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=benjamin@engflow.com \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.