From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Wolfram Sang <wsa@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
linux-sound@vger.kernel.org
Subject: Re: [PATCH v2 2/4] i2c: Replace list-based mechanism for handling auto-detected clients
Date: Fri, 1 Nov 2024 22:57:07 +0200 [thread overview]
Message-ID: <ZyVAo8eT-FjsI1gF@shikoro> (raw)
In-Reply-To: <228c7822-92bf-4939-abda-a2a21c74c18e@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
> I think this is right. However we may have the same issue already,
> w/o my patches. In i2c_del_adapter() the following isn't protected:
> device_for_each_child(&adap->dev, NULL, __unregister_client);
The drivers have been removed already at that time. By a block of code
which got removed in your patch:
1761 mutex_lock(&core_lock);
1762 bus_for_each_drv(&i2c_bus_type, NULL, adap,
1763 __process_removed_adapter);
1764 mutex_unlock(&core_lock);
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-11-01 20:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 19:45 [PATCH v2 0/4] i2c: Replace lists of special clients with flagging of such clients Heiner Kallweit
2024-08-22 19:47 ` [PATCH v2 1/4] ALSA: ppc: Remove i2c client removal hack Heiner Kallweit
2024-08-23 7:49 ` Takashi Iwai
2024-08-22 19:48 ` [PATCH v2 2/4] i2c: Replace list-based mechanism for handling auto-detected clients Heiner Kallweit
2024-10-08 8:50 ` Wolfram Sang
2024-10-08 9:20 ` Wolfram Sang
2024-11-01 7:36 ` Wolfram Sang
2024-11-01 20:45 ` Heiner Kallweit
2024-11-01 20:57 ` Wolfram Sang [this message]
2024-11-01 21:16 ` Heiner Kallweit
2024-08-22 19:48 ` [PATCH v2 3/4] i2c: Replace list-based mechanism for handling userspace-created clients Heiner Kallweit
2024-10-08 9:00 ` Wolfram Sang
2024-08-22 19:49 ` [PATCH v2 4/4] i2c: core: Remove obsolete members of i2c_adapter and i2c_client Heiner Kallweit
2024-10-08 9:00 ` Wolfram Sang
2024-10-08 10:59 ` Heiner Kallweit
2024-09-01 9:30 ` [PATCH v2 0/4] i2c: Replace lists of special clients with flagging of such clients Wolfram Sang
2024-09-01 20:08 ` Heiner Kallweit
2024-09-30 10:10 ` Heiner Kallweit
2024-09-30 10:59 ` Wolfram Sang
2024-10-08 8:43 ` Wolfram Sang
2024-10-08 11:31 ` Heiner Kallweit
2024-10-29 6:44 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyVAo8eT-FjsI1gF@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=hkallweit1@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.