From: Ming Lei <ming.lei@redhat.com>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de,
sagi@grimberg.me, axboe@fb.com, chaitanyak@nvidia.com,
dlemoal@kernel.org, gjoyce@linux.ibm.com
Subject: Re: [PATCHv3 1/2] Revert "nvme: make keep-alive synchronous operation"
Date: Mon, 4 Nov 2024 08:31:02 +0800 [thread overview]
Message-ID: <ZygVxkjQeOD_Jzy3@fedora> (raw)
In-Reply-To: <20241103181450.933737-2-nilay@linux.ibm.com>
On Sun, Nov 03, 2024 at 11:44:41PM +0530, Nilay Shroff wrote:
> This reverts commit d06923670b5a5f609603d4a9fee4dec02d38de9c.
>
> It was realized that the fix implemented to contain the race condition
> among the keep alive task and the fabric shutdown code path in the
> commit d06923670b5ia ("nvme: make keep-alive synchronous operation")
> is not optimal.
One good commit log is supposed to explain a bit why it isn't optimal
instead of "It was realized" without any details.
>
> We also found that the above race condition is a regression caused due
> to the changes implemented in commit a54a93d0e359 ("nvme: move stopping
> keep-alive into nvme_uninit_ctrl()"). So we decided to revert the commit
> d06923670b5a ("nvme: make keep-alive synchronous operation") and then
> fix the regression.
>
> Link: https://lore.kernel.org/all/196f4013-3bbf-43ff-98b4-9cb2a96c20c2@grimberg.me/
> Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
The patch itself looks good:
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
next prev parent reply other threads:[~2024-11-04 0:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 18:14 [PATCHv3 0/2] nvme: fix system fault observed while shutting down controller Nilay Shroff
2024-11-03 18:14 ` [PATCHv3 1/2] Revert "nvme: make keep-alive synchronous operation" Nilay Shroff
2024-11-04 0:31 ` Ming Lei [this message]
2024-11-05 6:07 ` Nilay Shroff
2024-11-03 18:14 ` [PATCHv3 2/2] nvme-fabrics: fix kernel crash while shutting down controller Nilay Shroff
2024-11-04 0:22 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZygVxkjQeOD_Jzy3@fedora \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=chaitanyak@nvidia.com \
--cc=dlemoal@kernel.org \
--cc=gjoyce@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.