From: Keith Busch <kbusch@kernel.org>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Keith Busch <kbusch@meta.com>,
linux-pci@vger.kernel.org, bhelgaas@google.com,
alex.williamson@redhat.com, ameynarkhede03@gmail.com,
raphael.norwitz@nutanix.com
Subject: Re: [PATCHv2 2/2] pci: warn if a running device is unaware of reset
Date: Mon, 4 Nov 2024 10:01:47 -0700 [thread overview]
Message-ID: <Zyj9-1kB3VhL6iZR@kbusch-mbp> (raw)
In-Reply-To: <d69d959038c80026a3f21811a126676d2b25b7c3.camel@linux.ibm.com>
On Mon, Nov 04, 2024 at 10:44:23AM +0100, Niklas Schnelle wrote:
>
> One more question though, what would happen with this reset for a bus
> with an SR-IOV device with more than 256 VFs i.e. where
> pci_iov_virtfn_bus() returns anything other than 0. I'm guessing since
> VFs are physically still controlled by the bridge all VFs would be
> reset but at the same time virtfn_add_bus() sets the bridge device for
> the added bus as NULL so I think it might look odd in sysfs, sadly I
> don't have such a device to test with. Still, this might actually be an
> argument for having the attribute on the bridge.
I assume everything is reset at the PCI level.
Are you asking what the kernel does? I don't think it does anything
special with SR-IOV functions. Those pci_dev's aren't attached to the
bridge pci_dev; you have to go through the pci_bus' children instead.
next prev parent reply other threads:[~2024-11-04 17:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 22:27 [PATCHv2 1/2] pci: provide bus reset attribute Keith Busch
2024-10-25 22:27 ` [PATCHv2 2/2] pci: warn if a running device is unaware of reset Keith Busch
2024-10-28 19:35 ` Alex Williamson
2024-10-29 11:27 ` Niklas Schnelle
2024-11-01 19:21 ` Keith Busch
2024-11-04 9:44 ` Niklas Schnelle
2024-11-04 17:01 ` Keith Busch [this message]
2024-11-05 12:28 ` Niklas Schnelle
2024-11-05 15:46 ` Keith Busch
2024-10-29 15:06 ` ameynarkhede03
2024-10-28 19:35 ` [PATCHv2 1/2] pci: provide bus reset attribute Alex Williamson
2024-10-29 15:05 ` ameynarkhede03
2024-11-04 21:28 ` Keith Busch
2024-11-04 21:53 ` Krzysztof Wilczyński
2024-11-04 21:58 ` Keith Busch
2024-11-04 22:42 ` Krzysztof Wilczy´nski
2024-11-12 19:12 ` Keith Busch
2024-11-12 23:16 ` Bjorn Helgaas
2024-11-13 17:38 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zyj9-1kB3VhL6iZR@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=ameynarkhede03@gmail.com \
--cc=bhelgaas@google.com \
--cc=kbusch@meta.com \
--cc=linux-pci@vger.kernel.org \
--cc=raphael.norwitz@nutanix.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.