From: Matthew Wilcox <willy@infradead.org>
To: Koichiro Den <koichiro.den@gmail.com>
Cc: vbabka@suse.cz, cl@linux.com, penberg@kernel.org,
rientjes@google.com, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, roman.gushchin@linux.dev,
42.hyeyoo@gmail.com, kees@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] mm/slab: fix warning caused by duplicate kmem_cache creation in kmem_buckets_create
Date: Mon, 4 Nov 2024 18:00:36 +0000 [thread overview]
Message-ID: <ZykLxG5Tyet5HcwL@casper.infradead.org> (raw)
In-Reply-To: <20241104150837.2756047-1-koichiro.den@gmail.com>
On Tue, Nov 05, 2024 at 12:08:37AM +0900, Koichiro Den wrote:
> Commit b035f5a6d852 ("mm: slab: reduce the kmalloc() minimum alignment
> if DMA bouncing possible") reduced ARCH_KMALLOC_MINALIGN to 8 on arm64.
> However, with KASAN_HW_TAGS enabled, arch_slab_minalign() becomes 16.
> This causes kmalloc_caches[*][8] to be aliased to kmalloc_caches[*][16],
> resulting in kmem_buckets_create() attempting to create a kmem_cache for
> size 16 twice. This duplication triggers warnings on boot:
Wouldn't this be easier?
+++ b/arch/arm64/include/asm/cache.h
@@ -33,7 +33,11 @@
* the CPU.
*/
#define ARCH_DMA_MINALIGN (128)
+#ifdef CONFIG_KASAN_HW_TAGS
+#define ARCH_KMALLOC_MINALIGN (16)
+#else
#define ARCH_KMALLOC_MINALIGN (8)
+#endif
#ifndef __ASSEMBLY__
next prev parent reply other threads:[~2024-11-04 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 15:08 [PATCH] mm/slab: fix warning caused by duplicate kmem_cache creation in kmem_buckets_create Koichiro Den
2024-11-04 15:40 ` Vlastimil Babka
2024-11-04 21:32 ` Kees Cook
2024-11-05 2:13 ` Koichiro Den
2024-11-04 18:00 ` Matthew Wilcox [this message]
2024-11-04 18:16 ` Vlastimil Babka
2024-11-04 22:22 ` Catalin Marinas
2024-11-04 22:28 ` Catalin Marinas
2024-11-05 2:30 ` Koichiro Den
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZykLxG5Tyet5HcwL@casper.infradead.org \
--to=willy@infradead.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kees@kernel.org \
--cc=koichiro.den@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.