All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Gushchin <roman.gushchin@linux.dev>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Alexey Gladkov <legion@kernel.org>,
	Andrei Vagin <avagin@google.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org, Kees Cook <kees@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] signal: restore the override_rlimit logic
Date: Mon, 4 Nov 2024 18:21:18 +0000	[thread overview]
Message-ID: <ZykQnp9mINnsPTg2@google.com> (raw)
In-Reply-To: <20241103165048.GA11668@redhat.com>

On Sun, Nov 03, 2024 at 05:50:49PM +0100, Oleg Nesterov wrote:
> On 11/02, Alexey Gladkov wrote:
> >
> > +Cc Oleg Nesterov.
> 
> Well, I tend to agree with Roman and his patch looks good to me.

Thanks, Oleg!

> 
> But it seems that the change in inc_rlimit_get_ucounts() can be
> a bit simpler and more readable, see below.

Eric suggested the same approach earlier in this thread. I personally
don't have a strong preference here or actually I slightly prefer my
own version because this comparison to LONG_MAX looks confusing to me.
But if you have a strong preference, I'm happy to send out v2. Please,
let me know.

Thanks!

  reply	other threads:[~2024-11-04 18:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 20:04 [PATCH] signal: restore the override_rlimit logic Roman Gushchin
2024-11-01 19:51 ` Eric W. Biederman
2024-11-01 20:38   ` Roman Gushchin
2024-11-01 20:58     ` Eric W. Biederman
2024-11-01 21:21       ` Roman Gushchin
2024-11-01 22:44       ` Andrei Vagin
2024-11-02 16:26         ` Alexey Gladkov
2024-11-03 16:50           ` Oleg Nesterov
2024-11-04 18:21             ` Roman Gushchin [this message]
2024-11-04 18:44               ` Oleg Nesterov
2024-11-04 19:02                 ` Alexey Gladkov
2024-11-04 19:42                   ` Roman Gushchin
2024-11-01 23:28 ` Alexey Gladkov
2024-11-01 23:50   ` Roman Gushchin
2024-11-02 13:46     ` Alexey Gladkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZykQnp9mINnsPTg2@google.com \
    --to=roman.gushchin@linux.dev \
    --cc=avagin@google.com \
    --cc=ebiederm@xmission.com \
    --cc=kees@kernel.org \
    --cc=legion@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.