From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:505:610b:b0:1be9:327d:8ee3 with SMTP id tt11csp2687735njc; Tue, 5 Nov 2024 01:06:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXM8uUi5MfGTQlPbPX4ZSWfOnXPMNdNrO1oqfnF62LoM7VKWCgg6VX9qaQciLIjBC0NKBtlr8HuMgzSXA==@linaro.org X-Google-Smtp-Source: AGHT+IFi65oz+Dg5Ok2NVCbeCNv+bFp8evtzfpieo3TWjy1CILJgFka5dEEi6V7RdWAnZW3t2pii X-Received: by 2002:a05:6102:3a0d:b0:4a3:db6a:dbbf with SMTP id ada2fe7eead31-4a962e13857mr12331352137.14.1730797614474; Tue, 05 Nov 2024 01:06:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1730797614; cv=none; d=google.com; s=arc-20240605; b=bIwMJl6eXTSVRbBDLqKiKEVlvV5IaGavbyPkgdIDJX/oPB9eh5br1tdzZ+FW4xbWxY vdqW2lFBzGKkkaiuH84/4xC3JabG2U60MsmRV8fUE5nhkoWLzYHWxpBc2zq0LkBC7eKo TejfmZINZTh9tAGxgvtX+lxFt9eIHcrYrXqpKyhyvmpfNCwnBnthWjHai3jGztLfW0CN 91rRv9I8OEvuTAlnpAme89McgoJU0O1sIQI4tK5fP/fZQjTHm8Iorw9XY7evnxda/6Vn P+fGD3hgBLpA11bVKP2KhjL6T2qW/bxuCGYs409oenrFx1GQ7qIfyZaE8ynjlHBepjDD bQiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:user-agent :in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:dkim-signature; bh=uXjIO+9s+KD2upHIWrfQy6arDb4vJIP8Rsh6ycWz53o=; fh=b/6h+kk+1q1aAw9aWX7lYt+LMRf5q5204sGfyobOJ3A=; b=ay1i+3QcncExHRcN3PmEXwCgl4tp2/ZIehzHM071hPFtrdKZMQtqsW+rC8fXk2oWyu fTALelJsJoXuSPL5ftEMeGBFG1tggsYtKDtcHvv9RtsiVVzFdcGGgAWidkGMsgBEI6Cy cxKKEfl17QOl0gz0VXEaWzTbfpt4qa34+3TN3Z35YgMPwTzIHCS6Nw5Xreeu9VFY1bB8 0KL9DgB/lr1sikf+tOr3z/KwmhIp15/fXTM//lH81foR1KNI5dpAiIxk15cgpyu3uB6V ly4jLILyPpeDK+ozBZQmAUdEkW3EQvacj+QI7pEfQ0g2cWHCr1ngnrbTBdSyl3MebkOB vjbg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MM8eGCwB; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-462ad1b2827si126525731cf.284.2024.11.05.01.06.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Nov 2024 01:06:54 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MM8eGCwB; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8FWR-0003rK-Q5; Tue, 05 Nov 2024 04:06:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8FWP-0003r0-9A for qemu-devel@nongnu.org; Tue, 05 Nov 2024 04:06:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8FWM-0002Xo-Og for qemu-devel@nongnu.org; Tue, 05 Nov 2024 04:06:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730797602; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=uXjIO+9s+KD2upHIWrfQy6arDb4vJIP8Rsh6ycWz53o=; b=MM8eGCwBb73//KJkIIs5Yq8Hz7dqapeyx2AlIrM0tJggElrYrNgeN7BZcdMuTi5u3CuJmy pN1ArNIh7vCOj5KM5yWPqs0GuSmxzeu38jZYUuQ/IQ4wrTPyPLGmqcnssmNv7eWTGNAjy7 HcJ3bsUwM7sr0PL8YVLicZ8Ct73TU+w= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-dGJxp6TLOD6SVWQW8zsXRw-1; Tue, 05 Nov 2024 04:06:39 -0500 X-MC-Unique: dGJxp6TLOD6SVWQW8zsXRw-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E6DEC1955F28; Tue, 5 Nov 2024 09:06:36 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.52]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A2C8B19560A2; Tue, 5 Nov 2024 09:06:30 +0000 (UTC) Date: Tue, 5 Nov 2024 09:06:26 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Peter Maydell , Jonathan Cameron , Markus Armbruster , "Huang, Ying" , Igor Mammedov , Ani Sinha , Shannon Zhao , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Eric Blake , qemu-arm@nongnu.org Subject: Re: [PULL 12/65] hw/acpi: Generic Port Affinity Structure support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: WDQSuCpGXbSv On Mon, Nov 04, 2024 at 04:06:16PM -0500, Michael S. Tsirkin wrote: > From: Jonathan Cameron > > These are very similar to the recently added Generic Initiators > but instead of representing an initiator of memory traffic they > represent an edge point beyond which may lie either targets or > initiators. Here we add these ports such that they may > be targets of hmat_lb records to describe the latency and > bandwidth from host side initiators to the port. A discoverable > mechanism such as UEFI CDAT read from CXL devices and switches > is used to discover the remainder of the path, and the OS can build > up full latency and bandwidth numbers as need for work and data > placement decisions. > > Acked-by: Markus Armbruster > Tested-by: "Huang, Ying" > Signed-off-by: Jonathan Cameron > Message-Id: <20240916174122.1843197-1-Jonathan.Cameron@huawei.com> > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > --- > qapi/qom.json | 41 ++++++++++ > include/hw/acpi/aml-build.h | 3 + > include/hw/acpi/pci.h | 2 +- > include/hw/pci/pci_bridge.h | 1 + > hw/acpi/aml-build.c | 39 ++++++++++ > hw/acpi/pci.c | 116 +++++++++++++++++++++++++++- > hw/arm/virt-acpi-build.c | 2 +- > hw/i386/acpi-build.c | 2 +- > hw/pci-bridge/pci_expander_bridge.c | 1 - > 9 files changed, 202 insertions(+), 5 deletions(-) > > diff --git a/qapi/qom.json b/qapi/qom.json > index 321ccd708a..a8beeabf1f 100644 > --- a/qapi/qom.json > +++ b/qapi/qom.json > @@ -844,6 +844,45 @@ > 'data': { 'pci-dev': 'str', > 'node': 'uint32' } } > > +## > +# @AcpiGenericPortProperties: > +# > +# Properties for acpi-generic-port objects. > +# > +# @pci-bus: QOM path of the PCI bus of the hostbridge associated with > +# this SRAT Generic Port Affinity Structure. This is the same as > +# the bus parameter for the root ports attached to this host > +# bridge. The resulting SRAT Generic Port Affinity Structure will > +# refer to the ACPI object in DSDT that represents the host bridge > +# (e.g. ACPI0016 for CXL host bridges). See ACPI 6.5 Section > +# 5.2.16.7 for more information. > +# > +# @node: Similar to a NUMA node ID, but instead of providing a > +# reference point used for defining NUMA distances and access > +# characteristics to memory or from an initiator (e.g. CPU), this > +# node defines the boundary point between non-discoverable system > +# buses which must be described by firmware, and a discoverable > +# bus. NUMA distances and access characteristics are defined to > +# and from that point. For system software to establish full > +# initiator to target characteristics this information must be > +# combined with information retrieved from the discoverable part > +# of the path. An example would use CDAT (see UEFI.org) > +# information read from devices and switches in conjunction with > +# link characteristics read from PCIe Configuration space. > +# To get the full path latency from CPU to CXL attached DRAM > +# CXL device: Add the latency from CPU to Generic Port (from > +# HMAT indexed via the the node ID in this SRAT structure) to > +# that for CXL bus links, the latency across intermediate switches > +# and from the EP port to the actual memory. Bandwidth is more > +# complex as there may be interleaving across multiple devices > +# and shared links in the path. > +# > +# Since: 9.1 This is outdated, we're in the 9.2 dev cycle currently. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|