From: Kevin Wolf <kwolf@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH 02/27] qemu-img: create: convert img_size to signed, simplify handling
Date: Tue, 5 Nov 2024 20:27:51 +0100 [thread overview]
Message-ID: <Zypxt0X5hxvyZg2w@redhat.com> (raw)
In-Reply-To: <20240927061121.573271-3-mjt@tls.msk.ru>
Am 27.09.2024 um 08:10 hat Michael Tokarev geschrieben:
> Initializing an unsigned as -1, or using temporary
> sval for conversion is awkward. Since we don't allow
> other "negative" values anyway, use signed value and
> pass it to bdrv_img_create() (where it is properly
> converted to unsigned), simplifying code.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2024-11-05 19:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 6:10 [PATCH resend v3 00/27] qemu-img: refersh options and --help handling, cleanups Michael Tokarev
2024-09-27 6:10 ` [PATCH 01/27] qemu-img: measure: convert img_size to signed, simplify handling Michael Tokarev
2024-11-05 19:27 ` Kevin Wolf
2024-09-27 6:10 ` [PATCH 02/27] qemu-img: create: " Michael Tokarev
2024-11-05 19:27 ` Kevin Wolf [this message]
2024-09-27 6:10 ` [PATCH 03/27] qemu-img: global option processing and error printing Michael Tokarev
2024-11-05 19:29 ` Kevin Wolf
2024-09-27 6:10 ` [PATCH 04/27] qemu-img: pass current cmd info into command handlers Michael Tokarev
2024-11-05 19:29 ` Kevin Wolf
2024-09-27 6:10 ` [PATCH 05/27] qemu-img: create: refresh options/--help Michael Tokarev
2024-11-05 19:57 ` Kevin Wolf
2024-09-27 6:11 ` [PATCH 06/27] qemu-img: factor out parse_output_format() and use it in the code Michael Tokarev
2025-05-13 15:25 ` Kevin Wolf
2024-09-27 6:11 ` [PATCH 07/27] qemu-img: check: refresh options/--help Michael Tokarev
2025-05-13 15:54 ` Kevin Wolf
2025-05-15 6:50 ` Michael Tokarev
2025-05-15 7:53 ` Kevin Wolf
2025-05-31 16:51 ` Michael Tokarev
2025-06-02 10:44 ` Kevin Wolf
2024-09-27 6:11 ` [PATCH 08/27] qemu-img: simplify --repair error message Michael Tokarev
2025-05-13 16:05 ` Kevin Wolf
2024-09-27 6:11 ` [PATCH 09/27] qemu-img: commit: refresh options/--help Michael Tokarev
2025-05-13 16:24 ` Kevin Wolf
2024-09-27 6:11 ` [PATCH 10/27] qemu-img: compare: " Michael Tokarev
2024-09-27 6:11 ` [PATCH 11/27] qemu-img: convert: " Michael Tokarev
2024-09-27 6:11 ` [PATCH 12/27] qemu-img: info: " Michael Tokarev
2024-09-27 6:11 ` [PATCH 13/27] qemu-img: map: " Michael Tokarev
2024-09-27 6:11 ` [PATCH 14/27] qemu-img: snapshot: allow specifying -f fmt Michael Tokarev
2024-09-27 6:11 ` [PATCH 15/27] qemu-img: snapshot: make -l (list) the default, simplify option handling Michael Tokarev
2024-09-27 6:11 ` [PATCH 16/27] qemu-img: snapshot: refresh options/--help Michael Tokarev
2024-09-27 6:11 ` [PATCH 17/27] qemu-img: rebase: " Michael Tokarev
2024-09-27 6:11 ` [PATCH 18/27] qemu-img: resize: do not always eat last argument Michael Tokarev
2024-09-27 6:11 ` [PATCH 19/27] qemu-img: resize: refresh options/--help Michael Tokarev
2024-09-27 6:11 ` [PATCH 20/27] qemu-img: amend: " Michael Tokarev
2024-09-27 6:11 ` [PATCH 21/27] qemu-img: bench: " Michael Tokarev
2024-09-27 6:11 ` [PATCH 22/27] qemu-img: bitmap: " Michael Tokarev
2024-09-27 6:11 ` [PATCH 23/27] qemu-img: dd: " Michael Tokarev
2024-09-27 6:11 ` [PATCH 24/27] qemu-img: measure: " Michael Tokarev
2024-09-27 6:11 ` [PATCH 25/27] qemu-img: implement short --help, remove global help() function Michael Tokarev
2024-09-27 6:11 ` [PATCH 26/27] qemu-img: inline list of supported commands, remove qemu-img-cmds.h include Michael Tokarev
2024-09-27 6:11 ` [PATCH 27/27] qemu-img: extend cvtnum() and use it in more places Michael Tokarev
2024-10-23 6:15 ` [PATCH resend v3 00/27] qemu-img: refersh options and --help handling, cleanups Michael Tokarev
-- strict thread matches above, loose matches on Subject: below --
2025-05-31 17:15 [PATCH v4 00/27] refresh qemu-img options handling Michael Tokarev
2025-05-31 17:15 ` [PATCH 02/27] qemu-img: create: convert img_size to signed, simplify handling Michael Tokarev
2024-04-24 8:50 [PATCH v3 00/27] qemu-img: refersh options and --help handling, cleanups Michael Tokarev
2024-04-24 8:50 ` [PATCH 02/27] qemu-img: create: convert img_size to signed, simplify handling Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zypxt0X5hxvyZg2w@redhat.com \
--to=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.