All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH] test: Remove duplicated check
Date: Tue, 5 Nov 2024 14:29:42 -0500	[thread overview]
Message-ID: <ZypyJrnIfntKB011@oracle.com> (raw)
In-Reply-To: <20241104192354.27566-1-eugene.loh@oracle.com>

On Mon, Nov 04, 2024 at 02:23:54PM -0500, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  test/unittest/usdt/tst.pidprobes.sh | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/test/unittest/usdt/tst.pidprobes.sh b/test/unittest/usdt/tst.pidprobes.sh
> index 8d18c89a4..25fee8553 100755
> --- a/test/unittest/usdt/tst.pidprobes.sh
> +++ b/test/unittest/usdt/tst.pidprobes.sh
> @@ -99,15 +99,6 @@ if [ $? -ne 0 ]; then
>  	cat dtrace.out
>  	exit 1
>  fi
> -echo "my result: 10" > main.out2.expected
> -if ! diff -q main.out2 main.out2.expected > /dev/null; then
> -	echo '"my result"' looks wrong when using DTrace
> -	echo === got ===
> -	cat main.out2
> -	echo === expected ===
> -	cat main.out2.expected
> -	exit 1
> -fi
>  
>  # Check that the program output is 10 when the USDT probe is enabled.
>  # That is, the PYRAMID_ENTRY_ENABLED() is-enabled checks should pass.
> @@ -115,7 +106,7 @@ fi
>  echo "my result: 10" > main.out2.expected
>  
>  if ! diff -q main.out2 main.out2.expected > /dev/null; then
> -	echo '"my result"' looks wrong
> +	echo '"my result"' looks wrong when using DTrace
>  	echo === got ===
>  	cat main.out2
>  	echo === expected ===
> -- 
> 2.43.5
> 

      reply	other threads:[~2024-11-05 19:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 19:23 [PATCH] test: Remove duplicated check eugene.loh
2024-11-05 19:29 ` Kris Van Hees [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZypyJrnIfntKB011@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=eugene.loh@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.