From: Sasha Levin <sashal@kernel.org>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: stable@vger.kernel.org, cs@tuxedo.de,
Takashi Iwai <tiwai@suse.de>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: FAILED: Patch "ALSA: hda/realtek: Fix headset mic on TUXEDO Gemini 17 Gen3" failed to apply to v6.1-stable tree
Date: Wed, 6 Nov 2024 07:00:58 -0500 [thread overview]
Message-ID: <ZytaejmvQo3NkUrP@sashalap> (raw)
In-Reply-To: <a7ab1da8-5fe8-4f46-bf18-bfc8d6fa3e6f@tuxedocomputers.com>
On Wed, Nov 06, 2024 at 10:23:14AM +0100, Werner Sembach wrote:
>Am 06.11.24 um 10:19 schrieb Werner Sembach:
>>Hi,
>>
>>Am 06.11.24 um 03:11 schrieb Sasha Levin:
>>>The patch below does not apply to the v6.1-stable tree.
>>>If someone wants it applied there, or to any other stable or longterm
>>>tree, then please email the backport, including the original git commit
>>>id to <stable@vger.kernel.org>.
>>
>>Applying 33affa7fb46c0c07f6c49d4ddac9dd436715064c (ALSA:
>>hda/realtek: Add quirks for some Clevo laptops) first and then
>>0b04fbe886b4274c8e5855011233aaa69fec6e75 (ALSA: hda/realtek: Fix
>>headset mic on TUXEDO Gemini 17 Gen3) and
>>e49370d769e71456db3fbd982e95bab8c69f73e8 (ALSA: hda/realtek: Fix
>>headset mic on TUXEDO Stellaris 16 Gen6 mb1) makes everything work
>>without alteration.
>>
>>The first one is just missing the cc stable tag, probably by accident.
>>
>>Should I alter the 2nd and 3rd commit or should I send a patchset
>>that includes the first one?
>
>Sorry just realized that for 5.15 it's a different patch that is
>missing for e49370d769e71456db3fbd982e95bab8c69f73e8 to cleanly apply
>
>I will just alter the patches
It applies, but fails to build:
In file included from sound/pci/hda/patch_realtek.c:21:
sound/pci/hda/patch_realtek.c:9530:59: error: 'ALC2XX_FIXUP_HEADSET_MIC' undeclared here (not in a function); did you mean 'ALC283_FIXUP_HEADSET_MIC'?
9530 | SND_PCI_QUIRK(0x1d05, 0x1387, "TongFang GMxIXxx", ALC2XX_FIXUP_HEADSET_MIC),
| ^~~~~~~~~~~~~~~~~~~~~~~~
./include/sound/core.h:465:50: note: in definition of macro 'SND_PCI_QUIRK'
465 | {_SND_PCI_QUIRK_ID(vend, dev), .value = (val), .name = (xname)}
| ^~~
make[3]: *** [scripts/Makefile.build:289: sound/pci/hda/patch_realtek.o] Error 1
--
Thanks,
Sasha
next prev parent reply other threads:[~2024-11-06 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 2:11 FAILED: Patch "ALSA: hda/realtek: Fix headset mic on TUXEDO Gemini 17 Gen3" failed to apply to v6.1-stable tree Sasha Levin
2024-11-06 9:19 ` Werner Sembach
2024-11-06 9:23 ` Werner Sembach
2024-11-06 12:00 ` Sasha Levin [this message]
2024-11-06 12:08 ` Werner Sembach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZytaejmvQo3NkUrP@sashalap \
--to=sashal@kernel.org \
--cc=cs@tuxedo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.