From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Dehan Meng <demeng@redhat.com>
Cc: qemu-devel@nongnu.org, kkostiuk@redhat.com, michael.roth@amd.com,
peter.maydell@linaro.org
Subject: Re: [PATCH v5 1/3] qemu-ga: Add 'Null' check and Redefine 'route'
Date: Wed, 6 Nov 2024 13:35:42 +0000 [thread overview]
Message-ID: <ZytwrvtfR6AxpkYZ@redhat.com> (raw)
In-Reply-To: <20241106084134.1133061-2-demeng@redhat.com>
On Wed, Nov 06, 2024 at 04:41:32PM +0800, Dehan Meng wrote:
> sscanf return values are checked and add 'Null' check for
> mandatory parameters. And merged redundant route and
> networkroute variables.
>
> Signed-off-by: Dehan Meng <demeng@redhat.com>
> ---
> qga/commands-linux.c | 86 +++++++++++++++++++++++---------------------
> 1 file changed, 45 insertions(+), 41 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-11-06 13:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 8:41 [PATCH v5 0/3] qemu-ga: Summarize and merge commits Dehan Meng
2024-11-06 8:41 ` [PATCH v5 1/3] qemu-ga: Add 'Null' check and Redefine 'route' Dehan Meng
2024-11-06 13:35 ` Daniel P. Berrangé [this message]
2024-11-06 16:43 ` Konstantin Kostiuk
2024-11-06 18:05 ` Konstantin Kostiuk
2024-11-06 8:41 ` [PATCH v5 2/3] qemu-ga: Optimize var declaration and definition Dehan Meng
2024-11-06 13:36 ` Daniel P. Berrangé
2024-11-06 16:44 ` Konstantin Kostiuk
2024-11-06 8:41 ` [PATCH v5 3/3] qemu-ga: Avoiding freeing line prematurely Dehan Meng
2024-11-06 13:38 ` Daniel P. Berrangé
2024-11-06 16:44 ` Konstantin Kostiuk
2024-11-06 18:07 ` Konstantin Kostiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZytwrvtfR6AxpkYZ@redhat.com \
--to=berrange@redhat.com \
--cc=demeng@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.