From: Keith Busch <kbusch@kernel.org>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-multipath: introduce service-time iopolicy
Date: Wed, 6 Nov 2024 09:07:46 -0700 [thread overview]
Message-ID: <ZyuUUokeCSsU_1-Y@kbusch-mbp> (raw)
In-Reply-To: <20241106103410.62157-1-kanie@linux.alibaba.com>
On Wed, Nov 06, 2024 at 06:34:10PM +0800, Guixin Liu wrote:
> + if (READ_ONCE(ns->head->subsys->iopolicy) == NVME_IOPOLICY_ST) {
> + atomic_add(blk_rq_bytes(rq), &ns->ctrl->inflight_size);
> + nvme_req(rq)->flags |= NVME_MPATH_CNT_IOSIZE;
> + }
...
> static inline struct nvme_request *nvme_req(struct request *req)
> @@ -367,6 +368,7 @@ struct nvme_ctrl {
> struct timer_list anatt_timer;
> struct work_struct ana_work;
> atomic_t nr_active;
> + atomic_t inflight_size;
You're counting bytes, so this should probably be an atomic64_t.
next prev parent reply other threads:[~2024-11-06 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 10:34 [PATCH] nvme-multipath: introduce service-time iopolicy Guixin Liu
2024-11-06 16:07 ` Keith Busch [this message]
2024-11-07 2:04 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyuUUokeCSsU_1-Y@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.