From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB77BD59F74 for ; Wed, 6 Nov 2024 20:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/DHszNOt4o1L1USKCkuHP6mgHhgm3F/Dpy7EQxrwpJY=; b=fz3Br1t3IWOOBd93yF6pUoQcwD t1QeFgRHeHcNJLqo5ufxhqFnbKPXfyhgy2eR10JsZ+pPUX+a53HJfbk1hY98Jyz9Bz5zprvDngPPF O8Z8SFj++LErH7kWhNN9oQUVA+efPgwnhGjWHlMYIjTa181TsBmJBZTtz0Iqx3kQC/SYsPnUOMezf qKpVvIIsWYNADwICa4nynW/CT6r4xTeNesjpBOanl1caSgpp0If/VYRLIKXglYq7qgYRSRoy5ZRaD It2DYZ16HlMLutmsgYf2c6FDbPYFClUM66xU0TfYmQAjHlv4MCZcQDc/Xo/Ihjk3nG7bFnMCyviZp kuTOgw9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t8mvw-00000004jHc-2Lq4; Wed, 06 Nov 2024 20:47:20 +0000 Received: from [2a01:e0a:828:c7c0:e2d5:5eff:fe2d:8e8] (helo=luna.linkmauve.fr) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t8mrI-00000004iUw-2c80; Wed, 06 Nov 2024 20:42:35 +0000 Received: by luna.linkmauve.fr (Postfix, from userid 1000) id 7CC2F15E5A9A; Wed, 06 Nov 2024 21:42:25 +0100 (CET) Date: Wed, 6 Nov 2024 21:42:25 +0100 From: Link Mauve To: Cristian Ciocaltea Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Sebastian Reichel , Luis de Arquer , Alexandre ARNOUD , kernel@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, FUKAUMI Naoki Subject: Re: [PATCH v2 2/5] arm64: dts: rockchip: Enable HDMI0 on rock-5b Message-ID: References: <20241019-rk3588-hdmi0-dt-v2-0-466cd80e8ff9@collabora.com> <20241019-rk3588-hdmi0-dt-v2-2-466cd80e8ff9@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241019-rk3588-hdmi0-dt-v2-2-466cd80e8ff9@collabora.com> Jabber-ID: linkmauve@linkmauve.fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241106_124232_832983_933FDF13 X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, I’ve tested this series on a Radxa Rock 5B using Weston, and thus patches 1 and 2 are: Tested-by: Link Mauve On a TV which erroneously reports 1360×768 as its preferred mode, nothing gets displayed. Only setting a 1920×1080 mode will display things correctly, every other mode stays black. Also, before starting Weston, drm_info reports Status: unknown, 0×0 mm, no modes, and no EDID blob. After starting Weston all of these property get loaded properly, aside from the physical size which gets set to the obviously invalid 1600×900 mm. The first start of Weston after reboot takes a total of 7.4s, which seems very long just to (I believe) probe the screen and parse the EDID, if that’s what the driver is doing. Subsequent launches complete in about 400 ms, which is closer to my expectation. Thanks a lot for this series! On Sat, Oct 19, 2024 at 01:12:11PM +0300, Cristian Ciocaltea wrote: > Add the necessary DT changes to enable HDMI0 on Radxa ROCK 5B. > > Tested-by: FUKAUMI Naoki > Signed-off-by: Cristian Ciocaltea > --- > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 47 +++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > index d6fff5b86b87020f115ce64795aee90c002a2255..0c3baf74981b714eb2a1edbc3fbbb69cd688cfc2 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > @@ -4,6 +4,7 @@ > > #include > #include > +#include > #include "rk3588.dtsi" > > / { > @@ -37,6 +38,17 @@ analog-sound { > pinctrl-0 = <&hp_detect>; > }; > > + hdmi0-con { > + compatible = "hdmi-connector"; > + type = "a"; > + > + port { > + hdmi0_con_in: endpoint { > + remote-endpoint = <&hdmi0_out_con>; > + }; > + }; > + }; > + > leds { > compatible = "gpio-leds"; > pinctrl-names = "default"; > @@ -192,6 +204,26 @@ &gpu { > status = "okay"; > }; > > +&hdmi0 { > + status = "okay"; > +}; > + > +&hdmi0_in { > + hdmi0_in_vp0: endpoint { > + remote-endpoint = <&vp0_out_hdmi0>; > + }; > +}; > + > +&hdmi0_out { > + hdmi0_out_con: endpoint { > + remote-endpoint = <&hdmi0_con_in>; > + }; > +}; > + > +&hdptxphy_hdmi0 { > + status = "okay"; > +}; > + > &i2c0 { > pinctrl-names = "default"; > pinctrl-0 = <&i2c0m2_xfer>; > @@ -858,3 +890,18 @@ &usb_host1_xhci { > &usb_host2_xhci { > status = "okay"; > }; > + > +&vop_mmu { > + status = "okay"; > +}; > + > +&vop { > + status = "okay"; > +}; > + > +&vp0 { > + vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 { > + reg = ; > + remote-endpoint = <&hdmi0_in_vp0>; > + }; > +}; > > -- > 2.47.0 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Link Mauve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A38BAD59F73 for ; Wed, 6 Nov 2024 20:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vYXITINCiCqQCHP6PwuZQ9x0lH/QUR4500vnlWKrWUM=; b=iVleAWkiM7n0hD IU91OWWzkZKImjz9rJjayofu3lel4Ful6ZEXMlBceqa25S3a5qmYSgf2P7fHOOQu8V4MXM1YCXcmx di/Z3zfzj5hX6FBY2ofNR33EktqVPqjsWkglf/vIBMXKfjHk+22PSsPpBv/EVIL6E/7Jyzs7GeXss SouI4m05th0c+iPDg1XCb1uW3ap4tVlpz8O3AnhsLBWpAHA5QVoCFyTRv1sxUyn+Xv0zGVxwltwIr /3bSQeHDODWH6GuxNuLVcmf/iZLv72+ZSTgYzGibYMRp2FmwPHFdsFT80rV2tii7gKaLhD/V5ddLw CQRTuXEOP2ar7yYt1bTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t8mvx-00000004jHy-2Fdu; Wed, 06 Nov 2024 20:47:21 +0000 Received: from [2a01:e0a:828:c7c0:e2d5:5eff:fe2d:8e8] (helo=luna.linkmauve.fr) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t8mrI-00000004iUw-2c80; Wed, 06 Nov 2024 20:42:35 +0000 Received: by luna.linkmauve.fr (Postfix, from userid 1000) id 7CC2F15E5A9A; Wed, 06 Nov 2024 21:42:25 +0100 (CET) Date: Wed, 6 Nov 2024 21:42:25 +0100 From: Link Mauve To: Cristian Ciocaltea Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Sebastian Reichel , Luis de Arquer , Alexandre ARNOUD , kernel@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, FUKAUMI Naoki Subject: Re: [PATCH v2 2/5] arm64: dts: rockchip: Enable HDMI0 on rock-5b Message-ID: References: <20241019-rk3588-hdmi0-dt-v2-0-466cd80e8ff9@collabora.com> <20241019-rk3588-hdmi0-dt-v2-2-466cd80e8ff9@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241019-rk3588-hdmi0-dt-v2-2-466cd80e8ff9@collabora.com> Jabber-ID: linkmauve@linkmauve.fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241106_124232_832983_933FDF13 X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGksCgpJ4oCZdmUgdGVzdGVkIHRoaXMgc2VyaWVzIG9uIGEgUmFkeGEgUm9jayA1QiB1c2luZyBX ZXN0b24sIGFuZCB0aHVzCnBhdGNoZXMgMSBhbmQgMiBhcmU6ClRlc3RlZC1ieTogTGluayBNYXV2 ZSA8bGlua21hdXZlQGxpbmttYXV2ZS5mcj4KCk9uIGEgVFYgd2hpY2ggZXJyb25lb3VzbHkgcmVw b3J0cyAxMzYww5c3NjggYXMgaXRzIHByZWZlcnJlZCBtb2RlLApub3RoaW5nIGdldHMgZGlzcGxh eWVkLiAgT25seSBzZXR0aW5nIGEgMTkyMMOXMTA4MCBtb2RlIHdpbGwgZGlzcGxheQp0aGluZ3Mg Y29ycmVjdGx5LCBldmVyeSBvdGhlciBtb2RlIHN0YXlzIGJsYWNrLgoKQWxzbywgYmVmb3JlIHN0 YXJ0aW5nIFdlc3RvbiwgZHJtX2luZm8gcmVwb3J0cyBTdGF0dXM6IHVua25vd24sIDDDlzAgbW0s Cm5vIG1vZGVzLCBhbmQgbm8gRURJRCBibG9iLiAgQWZ0ZXIgc3RhcnRpbmcgV2VzdG9uIGFsbCBv ZiB0aGVzZSBwcm9wZXJ0eQpnZXQgbG9hZGVkIHByb3Blcmx5LCBhc2lkZSBmcm9tIHRoZSBwaHlz aWNhbCBzaXplIHdoaWNoIGdldHMgc2V0IHRvIHRoZQpvYnZpb3VzbHkgaW52YWxpZCAxNjAww5c5 MDAgbW0uCgpUaGUgZmlyc3Qgc3RhcnQgb2YgV2VzdG9uIGFmdGVyIHJlYm9vdCB0YWtlcyBhIHRv dGFsIG9mIDcuNHMsIHdoaWNoCnNlZW1zIHZlcnkgbG9uZyBqdXN0IHRvIChJIGJlbGlldmUpIHBy b2JlIHRoZSBzY3JlZW4gYW5kIHBhcnNlIHRoZSBFRElELAppZiB0aGF04oCZcyB3aGF0IHRoZSBk cml2ZXIgaXMgZG9pbmcuICBTdWJzZXF1ZW50IGxhdW5jaGVzIGNvbXBsZXRlIGluCmFib3V0IDQw MCBtcywgd2hpY2ggaXMgY2xvc2VyIHRvIG15IGV4cGVjdGF0aW9uLgoKVGhhbmtzIGEgbG90IGZv ciB0aGlzIHNlcmllcyEKCk9uIFNhdCwgT2N0IDE5LCAyMDI0IGF0IDAxOjEyOjExUE0gKzAzMDAs IENyaXN0aWFuIENpb2NhbHRlYSB3cm90ZToKPiBBZGQgdGhlIG5lY2Vzc2FyeSBEVCBjaGFuZ2Vz IHRvIGVuYWJsZSBIRE1JMCBvbiBSYWR4YSBST0NLIDVCLgo+IAo+IFRlc3RlZC1ieTogRlVLQVVN SSBOYW9raSA8bmFva2lAcmFkeGEuY29tPgo+IFNpZ25lZC1vZmYtYnk6IENyaXN0aWFuIENpb2Nh bHRlYSA8Y3Jpc3RpYW4uY2lvY2FsdGVhQGNvbGxhYm9yYS5jb20+Cj4gLS0tCj4gIGFyY2gvYXJt NjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTg4LXJvY2stNWIuZHRzIHwgNDcgKysrKysrKysrKysr KysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgNDcgaW5zZXJ0aW9ucygrKQo+IAo+IGRp ZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU4OC1yb2NrLTViLmR0 cyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTg4LXJvY2stNWIuZHRzCj4gaW5k ZXggZDZmZmY1Yjg2Yjg3MDIwZjExNWNlNjQ3OTVhZWU5MGMwMDJhMjI1NS4uMGMzYmFmNzQ5ODFi NzE0ZWIyYTFlZGJjM2ZiYmI2OWNkNjg4Y2ZjMiAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jv b3QvZHRzL3JvY2tjaGlwL3JrMzU4OC1yb2NrLTViLmR0cwo+ICsrKyBiL2FyY2gvYXJtNjQvYm9v dC9kdHMvcm9ja2NoaXAvcmszNTg4LXJvY2stNWIuZHRzCj4gQEAgLTQsNiArNCw3IEBACj4gIAo+ ICAjaW5jbHVkZSA8ZHQtYmluZGluZ3MvZ3Bpby9ncGlvLmg+Cj4gICNpbmNsdWRlIDxkdC1iaW5k aW5ncy9sZWRzL2NvbW1vbi5oPgo+ICsjaW5jbHVkZSA8ZHQtYmluZGluZ3Mvc29jL3JvY2tjaGlw LHZvcDIuaD4KPiAgI2luY2x1ZGUgInJrMzU4OC5kdHNpIgo+ICAKPiAgLyB7Cj4gQEAgLTM3LDYg KzM4LDE3IEBAIGFuYWxvZy1zb3VuZCB7Cj4gIAkJcGluY3RybC0wID0gPCZocF9kZXRlY3Q+Owo+ ICAJfTsKPiAgCj4gKwloZG1pMC1jb24gewo+ICsJCWNvbXBhdGlibGUgPSAiaGRtaS1jb25uZWN0 b3IiOwo+ICsJCXR5cGUgPSAiYSI7Cj4gKwo+ICsJCXBvcnQgewo+ICsJCQloZG1pMF9jb25faW46 IGVuZHBvaW50IHsKPiArCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmaGRtaTBfb3V0X2Nvbj47Cj4g KwkJCX07Cj4gKwkJfTsKPiArCX07Cj4gKwo+ICAJbGVkcyB7Cj4gIAkJY29tcGF0aWJsZSA9ICJn cGlvLWxlZHMiOwo+ICAJCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4gQEAgLTE5Miw2ICsy MDQsMjYgQEAgJmdwdSB7Cj4gIAlzdGF0dXMgPSAib2theSI7Cj4gIH07Cj4gIAo+ICsmaGRtaTAg ewo+ICsJc3RhdHVzID0gIm9rYXkiOwo+ICt9Owo+ICsKPiArJmhkbWkwX2luIHsKPiArCWhkbWkw X2luX3ZwMDogZW5kcG9pbnQgewo+ICsJCXJlbW90ZS1lbmRwb2ludCA9IDwmdnAwX291dF9oZG1p MD47Cj4gKwl9Owo+ICt9Owo+ICsKPiArJmhkbWkwX291dCB7Cj4gKwloZG1pMF9vdXRfY29uOiBl bmRwb2ludCB7Cj4gKwkJcmVtb3RlLWVuZHBvaW50ID0gPCZoZG1pMF9jb25faW4+Owo+ICsJfTsK PiArfTsKPiArCj4gKyZoZHB0eHBoeV9oZG1pMCB7Cj4gKwlzdGF0dXMgPSAib2theSI7Cj4gK307 Cj4gKwo+ICAmaTJjMCB7Cj4gIAlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+ICAJcGluY3Ry bC0wID0gPCZpMmMwbTJfeGZlcj47Cj4gQEAgLTg1OCwzICs4OTAsMTggQEAgJnVzYl9ob3N0MV94 aGNpIHsKPiAgJnVzYl9ob3N0Ml94aGNpIHsKPiAgCXN0YXR1cyA9ICJva2F5IjsKPiAgfTsKPiAr Cj4gKyZ2b3BfbW11IHsKPiArCXN0YXR1cyA9ICJva2F5IjsKPiArfTsKPiArCj4gKyZ2b3Agewo+ ICsJc3RhdHVzID0gIm9rYXkiOwo+ICt9Owo+ICsKPiArJnZwMCB7Cj4gKwl2cDBfb3V0X2hkbWkw OiBlbmRwb2ludEBST0NLQ0hJUF9WT1AyX0VQX0hETUkwIHsKPiArCQlyZWcgPSA8Uk9DS0NISVBf Vk9QMl9FUF9IRE1JMD47Cj4gKwkJcmVtb3RlLWVuZHBvaW50ID0gPCZoZG1pMF9pbl92cDA+Owo+ ICsJfTsKPiArfTsKPiAKPiAtLSAKPiAyLjQ3LjAKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IExpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlz dAo+IExpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCgotLSAKTGluayBNYXV2 ZQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgt cm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hp cAo=