From: Carlos Llamas <cmllamas@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <brauner@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
"Mukesh Ojha" <quic_mojha@quicinc.com>
Subject: Re: [PATCH v2 1/8] Revert "binder: switch alloc->mutex to spinlock_t"
Date: Thu, 7 Nov 2024 14:30:18 +0000 [thread overview]
Message-ID: <ZyzO-vbufELmBlvf@google.com> (raw)
In-Reply-To: <2024110742-setup-clothing-44b8@gregkh>
On Thu, Nov 07, 2024 at 09:56:16AM +0100, Greg Kroah-Hartman wrote:
> On Thu, Nov 07, 2024 at 04:02:23AM +0000, Carlos Llamas wrote:
> > This reverts commit 7710e2cca32e7f3958480e8bd44f50e29d0c2509.
> >
> > In preparation for concurrent page installations, restore the original
> > alloc->mutex which will serialize zap_page_range_single() against page
> > installations in subsequent patches (instead of the mmap_sem).
> >
> > Cc: Mukesh Ojha <quic_mojha@quicinc.com>
> > [cmllamas: fix trivial conflict due to 2c10a20f5e84a]
>
> Nit, commits have the full name in them as well, not just the sha1 one,
> i.e.:
> 2c10a20f5e84 ("binder_alloc: Fix sleeping function called from invalid context")
>
Sounds good, done for v3.
Cheers,
Carlos Llamas
next prev parent reply other threads:[~2024-11-07 14:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 4:02 [PATCH v2 0/8] binder: faster page installations Carlos Llamas
2024-11-07 4:02 ` [PATCH v2 1/8] Revert "binder: switch alloc->mutex to spinlock_t" Carlos Llamas
2024-11-07 8:56 ` Greg Kroah-Hartman
2024-11-07 14:30 ` Carlos Llamas [this message]
2024-11-07 4:02 ` [PATCH v2 2/8] binder: concurrent page installation Carlos Llamas
2024-11-07 15:10 ` Suren Baghdasaryan
2024-11-07 15:31 ` Carlos Llamas
2024-11-07 4:02 ` [PATCH v2 3/8] binder: select correct nid for pages in LRU Carlos Llamas
2024-11-07 4:02 ` [PATCH v2 4/8] binder: remove struct binder_lru_page Carlos Llamas
2024-11-07 4:02 ` [PATCH v2 5/8] binder: use alloc->mapped to save the vma state Carlos Llamas
2024-11-07 4:02 ` [PATCH v2 6/8] binder: remove cached alloc->vma pointer Carlos Llamas
2024-11-07 15:33 ` Suren Baghdasaryan
2024-11-07 4:02 ` [PATCH v2 7/8] binder: rename alloc->buffer to vm_start Carlos Llamas
2024-11-07 4:02 ` [PATCH v2 8/8] binder: use per-vma lock in page installation Carlos Llamas
2024-11-07 16:16 ` Suren Baghdasaryan
2024-11-07 17:55 ` Carlos Llamas
2024-11-07 18:04 ` Suren Baghdasaryan
2024-11-07 18:19 ` Carlos Llamas
2024-11-07 18:27 ` Suren Baghdasaryan
2024-11-07 18:52 ` Suren Baghdasaryan
2024-11-07 19:33 ` Carlos Llamas
2024-11-07 19:40 ` Carlos Llamas
2024-11-07 16:18 ` [PATCH v2 0/8] binder: faster page installations Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyzO-vbufELmBlvf@google.com \
--to=cmllamas@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=quic_mojha@quicinc.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.