From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: konrad.wilk@oracle.com, ross.lagerwall@citrix.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 2/4] create-diff-object: update default alt_instr size
Date: Thu, 7 Nov 2024 16:55:03 +0100 [thread overview]
Message-ID: <Zyzi17UTGMRU_7Ql@macbook> (raw)
In-Reply-To: <28f3bcb5-ce01-48f6-b0a9-0ffa96998315@suse.com>
On Thu, Nov 07, 2024 at 04:20:35PM +0100, Jan Beulich wrote:
> On 07.11.2024 16:15, Roger Pau Monne wrote:
> > The size of the alt_instr structure in Xen is 14 instead of 12 bytes, adjust
> > it.
>
> Nowadays yes. Isn't the tool supposed to be usable with all livepatch-capable
> Xen versions, though? As a random data point, 4.7 still had the size at 12.
Yes, livepatch-build-tools will fetch the alt_intsrt size from the
DWARF info.
However when using create-diff-object without the env variable being
set a default value is used, and that's currently 12. I think it
would be best to update that default to the value used by the current
Xen version.
Thanks, Roger.
next prev parent reply other threads:[~2024-11-07 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 15:15 [PATCH 0/4] livepatch-build-tools: fix for livepatch hooks Roger Pau Monne
2024-11-07 15:15 ` [PATCH 1/4] livepatch-build: allow patch file name sizes up to 127 characters Roger Pau Monne
2025-01-21 10:29 ` Ross Lagerwall
2024-11-07 15:15 ` [PATCH 2/4] create-diff-object: update default alt_instr size Roger Pau Monne
2024-11-07 15:20 ` Jan Beulich
2024-11-07 15:55 ` Roger Pau Monné [this message]
2024-11-07 16:04 ` Jan Beulich
2025-01-21 10:31 ` Ross Lagerwall
2024-11-07 15:15 ` [PATCH 3/4] create-diff-object: don't include symbols for .livepatch.hooks.* sections Roger Pau Monne
2025-01-21 10:40 ` Ross Lagerwall
2024-11-07 15:15 ` [PATCH 4/4] create-diff-object: also include relas that point to changed sections Roger Pau Monne
2025-01-21 10:41 ` Ross Lagerwall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zyzi17UTGMRU_7Ql@macbook \
--to=roger.pau@citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=ross.lagerwall@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.