Re: [meta-virtualization][master][scarthgap][styhead][PATCH 0/6] Add bbclass for xen boot script variables

[Bruce Ashfield <bruce.ashfield@gmail.com>]

In message: [meta-virtualization][master][scarthgap][styhead][PATCH 0/6] Add bbclass for xen boot script variables
on 18/11/2024 Sandeep Gundlupet Raju wrote:

> 1. Add xen-u-boot-scr.bbclass for generic xen boot script variables
>    use by any soc devices.
> 2. Inherit xen-u-boot-scr.bbclass in xen-rpi-u-boot-scr.
> 3. Move xen variables to xen-boot-env.inc file in xilinx
>    dynamic layers.
> 4. Include xen-boot-env if BOOTMODE = "xen" switch is enabled.
> 5. Add load address to boot.cmd.xen script echo messages.
> 6. Inherit xen-u-boot-scr bbclass in xen-boot-env.inc.
> 7. If user brings in their own boot.cmd.xxx file they can just
>    inherit xen-u-boot-scr bbclass and use the generic xen boot
>    script variables.

Just one request for a slightly different bbclass name
and a question about BOOTMODE.

A quick v2, and I don't have any concerns about merging
the series.

Bruce

> 
> Sandeep Gundlupet Raju (6):
>   xen-u-boot-scr: Add bbclass for xen boot script variables
>   xen-rpi-u-boot-scr: Inherit xen-u-boot-scr bbclass
>   xen-boot-env: Move xen variables to inc file
>   u-boot-xlnx-scr: Include xen-boot-env if BOOTMODE is xen
>   boot.cmd.xen: Add load address to echo messages
>   xen-boot-env.inc: Inherit xen-u-boot-scr bbclass
> 
>  classes-recipe/xen-u-boot-scr.bbclass         | 43 +++++++++++++++++++
>  .../xen-rpi-u-boot-scr/files/boot.cmd.xen.in  | 10 ++---
>  .../xen-rpi-u-boot-scr/xen-rpi-u-boot-scr.bb  | 13 +++---
>  .../u-boot/u-boot-xlnx-scr.bbappend           |  7 ++-
>  .../u-boot/u-boot-xlnx-scr/boot.cmd.xen       |  8 ++--
>  .../recipes-bsp/u-boot/xen-boot-cmd.inc       | 35 ---------------
>  .../recipes-bsp/u-boot/xen-boot-env.inc       | 31 +++++++++++++
>  7 files changed, 97 insertions(+), 50 deletions(-)
>  create mode 100644 classes-recipe/xen-u-boot-scr.bbclass
>  create mode 100644 dynamic-layers/xilinx/recipes-bsp/u-boot/xen-boot-env.inc
> 
> -- 
> 2.34.1
>