From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marco Elver <elver@google.com>
Cc: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH v1 1/1] kcsan: debugfs: Use krealloc_array() to replace krealloc()
Date: Thu, 21 Nov 2024 16:16:23 +0200 [thread overview]
Message-ID: <Zz9AtzWWXW_mgjR6@smile.fi.intel.com> (raw)
In-Reply-To: <CANpmjNO8CRXPxBDFVa5XLYpPuU8Zof=7uvUam9ZFVPP9j8+TEQ@mail.gmail.com>
On Thu, Nov 21, 2024 at 03:11:41PM +0100, Marco Elver wrote:
> On Thu, 21 Nov 2024 at 15:04, Marco Elver <elver@google.com> wrote:
> > On Thu, 21 Nov 2024 at 14:58, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > Use krealloc_array() to replace krealloc() with multiplication.
> > > krealloc_array() has multiply overflow check, which will be safer.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Reviewed-by: Marco Elver <elver@google.com>
>
> Unreview.
>
> > Do you have a tree to take this through? Otherwise I'll take it.
>
> Whoops. We got rid of that krealloc() in 59458fa4ddb4 ("kcsan: Turn
> report_filterlist_lock into a raw_spinlock"). And the replacement
> kmalloc() is already a kmalloc_array(). I suppose this patch is
> therefore obsolete.
Ah, I made this on top of v6.12 + something most likely unrelated.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-11-21 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 13:58 [PATCH v1 1/1] kcsan: debugfs: Use krealloc_array() to replace krealloc() Andy Shevchenko
2024-11-21 14:04 ` Marco Elver
2024-11-21 14:11 ` Marco Elver
2024-11-21 14:16 ` Andy Shevchenko [this message]
2024-11-21 14:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zz9AtzWWXW_mgjR6@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.