From: Benjamin Marzinski <bmarzins@redhat.com>
To: Martin Wilck <martin.wilck@suse.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>,
device-mapper development <dm-devel@lists.linux.dev>
Subject: Re: [PATCH] libmultipath: Fix MAPINFO_CHECK_UUID with partitions
Date: Thu, 21 Nov 2024 13:46:17 -0500 [thread overview]
Message-ID: <Zz9_-QcFat49thMA@redhat.com> (raw)
In-Reply-To: <6f53bcf8b37d466e92609ab0a21672ff50914461.camel@suse.com>
On Thu, Nov 21, 2024 at 06:05:48PM +0100, Martin Wilck wrote:
> On Wed, 2024-11-20 at 19:17 -0500, Benjamin Marzinski wrote:
> > In libmp_mapinfo__(), if is_mpath_part_uuid() succeeded, instead of
> > ending the 'if' statement, is_mpath_uuid() would be called because of
> > the OR operator. This would always fail if is_mpath_part_uuid()
> > passed.
> > This meant that libmp_mapinfo__() could never match partitions with
> > MAPINFO_CHECK_UUID.
> >
> > Fix that by not calling is_mpath_uuid() if MAPINFO_PART_ONLY is set.
> >
> > Fixes: c1aa0285 ("libmultipath: make MAPINFO_CHECK_UUID work with
> > partitions")
> > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
>
> Ouch. Thanks!!
> Reviewed-by: Martin Wilck <mwilck@suse.com>
So, in theory the next step would be to open a PR for the upstream
stable branch, if that existed, right?
-Ben
next prev parent reply other threads:[~2024-11-21 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 0:17 [PATCH] libmultipath: Fix MAPINFO_CHECK_UUID with partitions Benjamin Marzinski
2024-11-21 17:05 ` Martin Wilck
2024-11-21 18:46 ` Benjamin Marzinski [this message]
2024-11-21 18:51 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zz9_-QcFat49thMA@redhat.com \
--to=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
--cc=martin.wilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.