All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Guangwu Zhang <guazhang@redhat.com>
Cc: linux-block@vger.kernel.org, io-uring@vger.kernel.org,
	Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [bug report] fio failed with --fixedbufs
Date: Mon, 11 Nov 2024 15:50:26 +0800	[thread overview]
Message-ID: <ZzG3Qk0wvKR67CoU@fedora> (raw)
In-Reply-To: <CAGS2=YqYbvNi6zu8e9e=R+gZMKwY_LegK2vi2MSgdsL1pMyDLA@mail.gmail.com>

Hi Guangwu,

On Mon, Nov 11, 2024 at 03:20:22PM +0800, Guangwu Zhang wrote:
> Hi,
> 
> Get the fio error like below, please have a look if something wrong  here,
> can not reproduce it if remove "--fixedbufs".
> 
> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
> Commit: 51b3526f50cf5526b73d06bd44a0f5e3f936fb01
> 

The issue should be fixed by the following patch:

diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c
index e7723759cb23..401c861ebc8e 100644
--- a/io_uring/uring_cmd.c
+++ b/io_uring/uring_cmd.c
@@ -221,6 +221,7 @@ int io_uring_cmd_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
                struct io_ring_ctx *ctx = req->ctx;
                struct io_rsrc_node *node;

+               req->buf_index = READ_ONCE(sqe->buf_index);
                node = io_rsrc_node_lookup(&ctx->buf_table, req->buf_index);
                if (unlikely(!node))
                        return -EFAULT;



Thanks,
Ming


  reply	other threads:[~2024-11-11  7:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-11  7:20 [bug report] fio failed with --fixedbufs Guangwu Zhang
2024-11-11  7:50 ` Ming Lei [this message]
2024-11-11  8:16   ` Guangwu Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZzG3Qk0wvKR67CoU@fedora \
    --to=ming.lei@redhat.com \
    --cc=guazhang@redhat.com \
    --cc=io-uring@vger.kernel.org \
    --cc=jmoyer@redhat.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.