From: Christoph Hellwig <hch@infradead.org>
To: Long Li <leo.lilong@huawei.com>
Cc: Christoph Hellwig <hch@infradead.org>,
djwong@kernel.org, cem@kernel.org, brauner@kernel.org,
linux-xfs@vger.kernel.org, david@fromorbit.com,
yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com,
lonuxli.64@gmail.com
Subject: Re: [PATCH] iomap: fix zero padding data issue in concurrent append writes
Date: Sun, 10 Nov 2024 21:45:19 -0800 [thread overview]
Message-ID: <ZzGZ76Qy7mCZo8a3@infradead.org> (raw)
In-Reply-To: <Zy8Lsee7EDodz5Xk@localhost.localdomain>
On Sat, Nov 09, 2024 at 03:13:53PM +0800, Long Li wrote:
> > Oh, interesting one. Do you have a reproducer we could wire up
> > to xfstests?
> >
>
> Yes, I have a simple reproducer, but it would require significant
> work to incorporate it into xfstestis.
Can you at least shared it? We might be able to help turning it into
a test.
> If we only use one size record, we can remove io_size and keep only
> io_end to record the tail end of valid file data in ioend. Meanwhile,
> we can add a wrapper function iomep_ioend_iosize() to get the extent
> size of ioend, replacing the existing ioend->io_size. Would this work?
I'd probably still use offset + size to avoid churn because it feels
more natural and causes less churn, but otherwise this sounds good to
me.
next prev parent reply other threads:[~2024-11-11 5:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 12:27 [PATCH] iomap: fix zero padding data issue in concurrent append writes Long Li
2024-11-08 14:55 ` Christoph Hellwig
2024-11-09 7:13 ` Long Li
2024-11-11 5:45 ` Christoph Hellwig [this message]
2024-11-11 14:16 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzGZ76Qy7mCZo8a3@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=houtao1@huawei.com \
--cc=leo.lilong@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lonuxli.64@gmail.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.