From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
Cc: intel-xe@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org, david.e.box@linux.intel.com,
ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com,
rodrigo.vivi@intel.com, lucas.demarchi@intel.com
Subject: Re: [PATCH 1/2] platform/x86/intel/pmt: allow user offset for PMT callbacks
Date: Mon, 11 Nov 2024 10:34:14 +0200 [thread overview]
Message-ID: <ZzHBhsJ_J3ARhLu9@smile.fi.intel.com> (raw)
In-Reply-To: <20241108201955.2048085-1-michael.j.ruhl@intel.com>
On Fri, Nov 08, 2024 at 03:19:53PM -0500, Michael J. Ruhl wrote:
> Usage of the telem sysfs file allows for partial reads at
> an offset.
>
> The current callback method returns the buffer starting
> from offset 0 only.
>
> Include the requested offset in the callback.
> Update the necsessary address calculations with the offset.
...
> - memcpy_fromio(buf, addr, count);
> + memcpy_fromio(buf, addr + off, count);
This will give an unaligned IO access in some cases. Is it a problem?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-11-11 8:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 20:19 [PATCH 1/2] platform/x86/intel/pmt: allow user offset for PMT callbacks Michael J. Ruhl
2024-11-08 20:19 ` [PATCH 2/2] drm/xe/vsec: Support BMG devices Michael J. Ruhl
2024-11-11 8:39 ` Andy Shevchenko
2024-11-12 14:48 ` Ruhl, Michael J
2024-11-08 20:39 ` ✓ CI.Patch_applied: success for series starting with [1/2] platform/x86/intel/pmt: allow user offset for PMT callbacks Patchwork
2024-11-08 20:39 ` ✗ CI.checkpatch: warning " Patchwork
2024-11-08 20:41 ` ✓ CI.KUnit: success " Patchwork
2024-11-08 21:01 ` ✓ CI.Build: " Patchwork
2024-11-08 21:03 ` ✓ CI.Hooks: " Patchwork
2024-11-08 21:05 ` ✓ CI.checksparse: " Patchwork
2024-11-08 21:47 ` ✓ CI.BAT: " Patchwork
2024-11-09 23:58 ` ✗ CI.FULL: failure " Patchwork
2024-11-11 8:34 ` Andy Shevchenko [this message]
2024-11-12 14:38 ` [PATCH 1/2] " Ruhl, Michael J
2024-11-12 15:27 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzHBhsJ_J3ARhLu9@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=michael.j.ruhl@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.