From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Luo Yifan <luoyifan@cmss.chinamobile.com>
Cc: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Remove redundant variable assignment
Date: Mon, 11 Nov 2024 14:42:41 -0300 [thread overview]
Message-ID: <ZzJCEadEKi8LiSTm@x1> (raw)
In-Reply-To: <20241111082713.274761-1-luoyifan@cmss.chinamobile.com>
On Mon, Nov 11, 2024 at 04:27:13PM +0800, Luo Yifan wrote:
> This patch makes a minor change that removes the redundant assignment
> to the variable ret, simplifying the code.
Thanks, applied to perf-tools-next,
- Arnaldo
> Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com>
> ---
> tools/perf/jvmti/jvmti_agent.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tools/perf/jvmti/jvmti_agent.c b/tools/perf/jvmti/jvmti_agent.c
> index 526dcaf9f..751219143 100644
> --- a/tools/perf/jvmti/jvmti_agent.c
> +++ b/tools/perf/jvmti/jvmti_agent.c
> @@ -408,9 +408,7 @@ jvmti_write_code(void *agent, char const *sym,
>
> funlockfile(fp);
>
> - ret = 0;
> -
> - return ret;
> + return 0;
> }
>
> int
> --
> 2.27.0
>
>
next prev parent reply other threads:[~2024-11-11 17:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 8:27 [PATCH] perf tools: Remove redundant variable assignment Luo Yifan
2024-11-11 17:42 ` Arnaldo Carvalho de Melo [this message]
2024-11-11 17:51 ` Arnaldo Carvalho de Melo
2024-11-11 17:53 ` Arnaldo Carvalho de Melo
2024-11-12 1:49 ` Luo Yifan
2024-11-12 6:01 ` [PATCH] perf jvmti: Remove unnecessary ret variable in jvmti_write_code Luo Yifan
2024-11-12 6:47 ` Luo Yifan
2024-11-12 6:58 ` [PATCH] perf jvmti: Properly handle return value checks " Luo Yifan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzJCEadEKi8LiSTm@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=luoyifan@cmss.chinamobile.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.