Re: (subset) [PATCH V10 0/12] io_uring: support group buffer & ublk zc

[Ming Lei <ming.lei@redhat.com>]

On Thu, Nov 07, 2024 at 03:25:59PM -0700, Jens Axboe wrote:
> On 11/7/24 3:25 PM, Jens Axboe wrote:
> > 
> > On Thu, 07 Nov 2024 19:01:33 +0800, Ming Lei wrote:
> >> Patch 1~3 cleans rsrc code.
> >>
> >> Patch 4~9 prepares for supporting kernel buffer.
> >>
> >> The 10th patch supports group buffer, so far only kernel buffer is
> >> supported, but it is pretty easy to extend for userspace group buffer.
> >>
> >> [...]
> > 
> > Applied, thanks!
> > 
> > [01/12] io_uring/rsrc: pass 'struct io_ring_ctx' reference to rsrc helpers
> >         commit: 0d98c509086837a8cf5a32f82f2a58f39a539192
> > [02/12] io_uring/rsrc: remove '->ctx_ptr' of 'struct io_rsrc_node'
> >         commit: 4f219fcce5e4366cc121fc98270beb1fbbb3df2b
> > [03/12] io_uring/rsrc: add & apply io_req_assign_buf_node()
> >         commit: 039c878db7add23c1c9ea18424c442cce76670f9
> 
> Applied the first three as they stand alone quite nicely. I did ponder
> on patch 1 to skip the make eg io_alloc_file_tables() not take both
> the ctx and &ctx->file_table, but we may as well keep it symmetric.
> 
> I'll take a look at the rest of the series tomorrow.

Hi Jens,

Any comment on the rest of the series?


thanks,
Ming