From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jenishkumar Maheshbhai Patel <jpatel2@marvell.com>
Cc: andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, salee@marvell.com,
dingwei@marvell.com
Subject: Re: [PATCH 1/1] arm64: dts: marvell: mcbin: fix PCIe reset property
Date: Tue, 12 Nov 2024 09:21:20 +0000 [thread overview]
Message-ID: <ZzMeELwScAMdrkQ6@shell.armlinux.org.uk> (raw)
In-Reply-To: <20241112072049.765097-1-jpatel2@marvell.com>
On Mon, Nov 11, 2024 at 11:20:49PM -0800, Jenishkumar Maheshbhai Patel wrote:
> Set reset gpio to active high
>
> Fixes: b83e1669adce ("arm64: dts: marvell: mcbin: add support for PCIe")
>
> Signed-off-by: Jenishkumar Maheshbhai Patel <jpatel2@marvell.com>
> ---
> arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> index c864df9ec84d..a8c732a47360 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> @@ -181,7 +181,7 @@ &cp0_pcie0 {
> pinctrl-0 = <&cp0_pcie_pins>;
> num-lanes = <4>;
> num-viewport = <8>;
> - reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_LOW>;
> + reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_HIGH>;
Is this change due to switching the driver to use the reset controller?
If so, NAK to all the changes - DT files are meant to be forwards
compatible (older DT are supposed to work with newer kernels) and it
would seem this would break that rule.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2024-11-12 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 7:20 [PATCH 1/1] arm64: dts: marvell: mcbin: fix PCIe reset property Jenishkumar Maheshbhai Patel
2024-11-12 9:21 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzMeELwScAMdrkQ6@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dingwei@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=jpatel2@marvell.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=salee@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.