From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Qi.Chen@windriver.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] criu: fix buildpaths QA issue for arm
Date: Tue, 12 Nov 2024 23:15:07 +0000 [thread overview]
Message-ID: <ZzPhe+/jQXlyTk4w@gmail.com> (raw)
In-Reply-To: <20241105073644.3692715-1-Qi.Chen@windriver.com>
merged.
Bruce
In message: [meta-virtualization][PATCH] criu: fix buildpaths QA issue for arm
on 04/11/2024 Chen Qi via lists.yoctoproject.org wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> The settings of CFLAGS:arm overrides the previous CFLAGS settings,
> causing buildpaths QA error for arm. Use CFLAGS:append:arm instead
> to fix this issue.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> recipes-containers/criu/criu_git.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-containers/criu/criu_git.bb b/recipes-containers/criu/criu_git.bb
> index 09503624..8ecc1725 100644
> --- a/recipes-containers/criu/criu_git.bb
> +++ b/recipes-containers/criu/criu_git.bb
> @@ -46,7 +46,7 @@ EXTRA_OEMAKE:append = " LOGROTATEDIR=${sysconfdir} SYSTEMDUNITDIR=${systemd_unit
> CFLAGS += "-D__USE_GNU -D_GNU_SOURCE "
>
> CFLAGS += " -I${STAGING_INCDIR} -I${STAGING_INCDIR}/libnl3"
> -CFLAGS:arm += "-D__WORDSIZE"
> +CFLAGS:append:arm = " -D__WORDSIZE"
>
> # overide LDFLAGS to allow criu to build without: "x86_64-poky-linux-ld: unrecognized option '-Wl,-O1'"
> export LDFLAGS=""
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8957): https://lists.yoctoproject.org/g/meta-virtualization/message/8957
> Mute This Topic: https://lists.yoctoproject.org/mt/109402190/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
prev parent reply other threads:[~2024-11-12 23:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 7:36 [meta-virtualization][PATCH] criu: fix buildpaths QA issue for arm Qi.Chen
2024-11-12 23:15 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzPhe+/jQXlyTk4w@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=Qi.Chen@windriver.com \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.