All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Qi.Chen@windriver.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][scarthgap][PATCH] libvirt: set USERADD_DEPENDS to avoid package_write_rpm failure
Date: Tue, 12 Nov 2024 23:22:08 +0000	[thread overview]
Message-ID: <ZzPjIJFxC/GX5trw@gmail.com> (raw)
In-Reply-To: <a7624c48-9683-41eb-a5eb-146f45ce5061@windriver.com>



In message: Re: [meta-virtualization][scarthgap][PATCH] libvirt: set USERADD_DEPENDS to avoid package_write_rpm failure
on 08/11/2024 Chen Qi via lists.yoctoproject.org wrote:

> I didn't sent this patch for master branch because master branch has changed
> the polkit part and there's no chown there.
> So this patch is only suitable for scarthgap.

I was wondering just that! thanks for the explanation, this is now merged.

Bruce

> 
> Regards,
> Qi
> 
> On 11/8/24 10:55, Chen Qi via lists.yoctoproject.org wrote:
> > From: Chen Qi <Qi.Chen@windriver.com>
> > 
> > When do_package uses state cache and is not re-run but do_package_write_rpm
> > is re-run, then we get the following error:
> > 
> >    Exception: KeyError: 'getpwuid(): uid not found: 996'
> > 
> > This is because libvirt does chown to polkitd in do_install and polkitd
> > is from polkit.
> > 
> > Here's an easy way to reproduce this issue:
> > 
> >    bitbake libvirt -c cleansstate && bitbake libvirt -c package && \
> >    bitbake libvirt -c clean && bitbake libvirt -c package_write_rpm
> > 
> > So make use of USERADD_DEPENDS to ensure polkitd exists to fix this issue.
> > 
> > Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> > ---
> >   recipes-extended/libvirt/libvirt_10.0.0.bb | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/recipes-extended/libvirt/libvirt_10.0.0.bb b/recipes-extended/libvirt/libvirt_10.0.0.bb
> > index a33b6980..22193ff3 100644
> > --- a/recipes-extended/libvirt/libvirt_10.0.0.bb
> > +++ b/recipes-extended/libvirt/libvirt_10.0.0.bb
> > @@ -11,6 +11,8 @@ DEPENDS = "bridge-utils gnutls libxml2 lvm2 avahi parted curl libpcap util-linux
> >   	   ${@bb.utils.contains('PACKAGECONFIG', 'polkit', 'shadow-native', '', d)} \
> >   	   ${@bb.utils.contains('PACKAGECONFIG', 'gnutls', 'gnutls-native', '', d)}"
> > +USERADD_DEPENDS = "${@bb.utils.contains('PACKAGECONFIG', 'polkit', 'polkit', '', d)}"
> > +
> >   # libvirt-guests.sh needs gettext.sh
> >   #
> >   RDEPENDS:${PN} = "gettext-runtime"
> > 
> > 
> > 
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8961): https://lists.yoctoproject.org/g/meta-virtualization/message/8961
> Mute This Topic: https://lists.yoctoproject.org/mt/109457527/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



  reply	other threads:[~2024-11-12 23:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1805DEC3FAC3F34F.28149@lists.yoctoproject.org>
2024-11-08  2:59 ` [meta-virtualization][scarthgap][PATCH] libvirt: set USERADD_DEPENDS to avoid package_write_rpm failure ChenQi
2024-11-12 23:22   ` Bruce Ashfield [this message]
2024-11-08  2:55 Qi.Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZzPjIJFxC/GX5trw@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=Qi.Chen@windriver.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.