All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Petr Machata <petrm@nvidia.com>,
	Richard Cochran <richardcochran@gmail.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv3 net-next] net: mellanox: use ethtool string helpers
Date: Wed, 13 Nov 2024 11:37:42 +0200	[thread overview]
Message-ID: <ZzRzZpReQM0JCACW@shredder> (raw)
In-Reply-To: <20241112211711.7593-1-rosenp@gmail.com>

Thanks for the patch, but there are a few process issues.

On Tue, Nov 12, 2024 at 01:17:11PM -0800, Rosen Penev wrote:
> These are the preferred way to copy ethtool strings.
> 
> Avoids incrementing pointers all over the place.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>

I only tagged the mlxsw change. The mlxbf change is new.

> ---
>  v3: also convert memcpy.
>  v2: rebase to make it apply.
>  .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  |  5 +-

Please split the mlxbf change to a different patch and copy the relevant
maintainers:

davthompson@nvidia.com
asmaa@nvidia.com

Use "mlxbf_gige:" prefix for the mlxbf patch and "mlxsw:" for the mlxsw
patch. You can keep my tag on the latter.


>  .../mellanox/mlxsw/spectrum_ethtool.c         | 83 +++++++------------
>  .../ethernet/mellanox/mlxsw/spectrum_ptp.c    |  7 +-
>  3 files changed, 33 insertions(+), 62 deletions(-)

      reply	other threads:[~2024-11-13  9:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 21:17 [PATCHv3 net-next] net: mellanox: use ethtool string helpers Rosen Penev
2024-11-13  9:37 ` Ido Schimmel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZzRzZpReQM0JCACW@shredder \
    --to=idosch@nvidia.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=richardcochran@gmail.com \
    --cc=rosenp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.