Re: [PATCH] hw/net/rocker/rocker_of_dpa.c: Remove superfluous error check

["Ján Tomko" <jtomko@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

On a Tuesday in 2024, Rodrigo Dias Correa wrote:
>of_dpa_cmd_add_acl_ip() is called from a single place, and despite the
>fact that it always returns ROCKER_OK, its return value is still checked
>by the caller.
>Change of_dpa_cmd_add_acl_ip() to return void and remove the superfluous
>check from of_dpa_cmd_add_acl().
>Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2471
>
>Signed-off-by: Rodrigo Dias Correa <r@drigo.nl>
>---
> hw/net/rocker/rocker_of_dpa.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
>diff --git a/hw/net/rocker/rocker_of_dpa.c b/hw/net/rocker/rocker_of_dpa.c
>index 5e16056be6..6d29130ec2 100644
>--- a/hw/net/rocker/rocker_of_dpa.c
>+++ b/hw/net/rocker/rocker_of_dpa.c
>@@ -1635,7 +1635,7 @@ static int of_dpa_cmd_add_multicast_routing(OfDpaFlow *flow,
>     return ROCKER_OK;
> }
>
>-static int of_dpa_cmd_add_acl_ip(OfDpaFlowKey *key, OfDpaFlowKey *mask,
>+static void of_dpa_cmd_add_acl_ip(OfDpaFlowKey *key, OfDpaFlowKey *mask,
>                                  RockerTlv **flow_tlvs)

The second line is misalgined.

> {
>     key->width = FLOW_KEY_WIDTH(ip.tos);

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]